add no-unused and react/recommended to eslint (#1523)

* add no-unused-vars and no-unused-imports

* added quotes: double, and remove ignore pattern

* move itif and describeif into utils

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/common/__tests__/cluster-store.test.ts

@@ -13,8 +13,8 @@ describe("empty config", () => {
   beforeEach(() => {
     ClusterStore.resetInstance();
     const mockOpts = {
-      'tmp': {
-        'lens-cluster-store.json': JSON.stringify({})
+      "tmp": {
+        "lens-cluster-store.json": JSON.stringify({})
       }
     };
     mockFs(mockOpts);
@@ -144,8 +144,8 @@ describe("config with existing clusters", () => {
   beforeEach(() => {
     ClusterStore.resetInstance();
     const mockOpts = {
-      'tmp': {
-        'lens-cluster-store.json': JSON.stringify({
+      "tmp": {
+        "lens-cluster-store.json": JSON.stringify({
           __internal__: {
             migrations: {
               version: "99.99.99"
@@ -153,24 +153,24 @@ describe("config with existing clusters", () => {
           },
           clusters: [
             {
-              id: 'cluster1',
-              kubeConfig: 'foo',
-              contextName: 'foo',
-              preferences: { terminalCWD: '/foo' },
-              workspace: 'default'
+              id: "cluster1",
+              kubeConfig: "foo",
+              contextName: "foo",
+              preferences: { terminalCWD: "/foo" },
+              workspace: "default"
             },
             {
-              id: 'cluster2',
-              kubeConfig: 'foo2',
-              contextName: 'foo2',
-              preferences: { terminalCWD: '/foo2' }
+              id: "cluster2",
+              kubeConfig: "foo2",
+              contextName: "foo2",
+              preferences: { terminalCWD: "/foo2" }
             },
             {
-              id: 'cluster3',
-              kubeConfig: 'foo',
-              contextName: 'foo',
-              preferences: { terminalCWD: '/foo' },
-              workspace: 'foo'
+              id: "cluster3",
+              kubeConfig: "foo",
+              contextName: "foo",
+              preferences: { terminalCWD: "/foo" },
+              workspace: "foo"
             },
           ]
         })
@@ -186,27 +186,27 @@ describe("config with existing clusters", () => {
   });
 
   it("allows to retrieve a cluster", () => {
-    const storedCluster = clusterStore.getById('cluster1');
-    expect(storedCluster.id).toBe('cluster1');
-    expect(storedCluster.preferences.terminalCWD).toBe('/foo');
+    const storedCluster = clusterStore.getById("cluster1");
+    expect(storedCluster.id).toBe("cluster1");
+    expect(storedCluster.preferences.terminalCWD).toBe("/foo");
   });
 
   it("allows to delete a cluster", () => {
-    clusterStore.removeById('cluster2');
-    const storedCluster = clusterStore.getById('cluster1');
+    clusterStore.removeById("cluster2");
+    const storedCluster = clusterStore.getById("cluster1");
     expect(storedCluster).toBeTruthy();
-    const storedCluster2 = clusterStore.getById('cluster2');
+    const storedCluster2 = clusterStore.getById("cluster2");
     expect(storedCluster2).toBeUndefined();
   });
 
   it("allows getting all of the clusters", async () => {
     const storedClusters = clusterStore.clustersList;
     expect(storedClusters.length).toBe(3);
-    expect(storedClusters[0].id).toBe('cluster1');
-    expect(storedClusters[0].preferences.terminalCWD).toBe('/foo');
-    expect(storedClusters[1].id).toBe('cluster2');
-    expect(storedClusters[1].preferences.terminalCWD).toBe('/foo2');
-    expect(storedClusters[2].id).toBe('cluster3');
+    expect(storedClusters[0].id).toBe("cluster1");
+    expect(storedClusters[0].preferences.terminalCWD).toBe("/foo");
+    expect(storedClusters[1].id).toBe("cluster2");
+    expect(storedClusters[1].preferences.terminalCWD).toBe("/foo2");
+    expect(storedClusters[2].id).toBe("cluster3");
   });
 });
 
@@ -214,14 +214,14 @@ describe("pre 2.0 config with an existing cluster", () => {
   beforeEach(() => {
     ClusterStore.resetInstance();
     const mockOpts = {
-      'tmp': {
-        'lens-cluster-store.json': JSON.stringify({
+      "tmp": {
+        "lens-cluster-store.json": JSON.stringify({
           __internal__: {
             migrations: {
               version: "1.0.0"
             }
           },
-          cluster1: 'kubeconfig content'
+          cluster1: "kubeconfig content"
         })
       }
     };
@@ -244,8 +244,8 @@ describe("pre 2.6.0 config with a cluster that has arrays in auth config", () =>
   beforeEach(() => {
     ClusterStore.resetInstance();
     const mockOpts = {
-      'tmp': {
-        'lens-cluster-store.json': JSON.stringify({
+      "tmp": {
+        "lens-cluster-store.json": JSON.stringify({
           __internal__: {
             migrations: {
               version: "2.4.1"
@@ -270,8 +270,8 @@ describe("pre 2.6.0 config with a cluster that has arrays in auth config", () =>
     const file = clusterStore.clustersList[0].kubeConfigPath;
     const config = fs.readFileSync(file, "utf8");
     const kc = yaml.safeLoad(config);
-    expect(kc.users[0].user['auth-provider'].config['access-token']).toBe("should be string");
-    expect(kc.users[0].user['auth-provider'].config['expiry']).toBe("should be string");
+    expect(kc.users[0].user["auth-provider"].config["access-token"]).toBe("should be string");
+    expect(kc.users[0].user["auth-provider"].config["expiry"]).toBe("should be string");
   });
 });
 
@@ -279,8 +279,8 @@ describe("pre 2.6.0 config with a cluster icon", () => {
   beforeEach(() => {
     ClusterStore.resetInstance();
     const mockOpts = {
-      'tmp': {
-        'lens-cluster-store.json': JSON.stringify({
+      "tmp": {
+        "lens-cluster-store.json": JSON.stringify({
           __internal__: {
             migrations: {
               version: "2.4.1"
@@ -308,8 +308,8 @@ describe("pre 2.6.0 config with a cluster icon", () => {
 
   it("moves the icon into preferences", async () => {
     const storedClusterData = clusterStore.clustersList[0];
-    expect(storedClusterData.hasOwnProperty('icon')).toBe(false);
-    expect(storedClusterData.preferences.hasOwnProperty('icon')).toBe(true);
+    expect(storedClusterData.hasOwnProperty("icon")).toBe(false);
+    expect(storedClusterData.preferences.hasOwnProperty("icon")).toBe(true);
     expect(storedClusterData.preferences.icon.startsWith("data:;base64,")).toBe(true);
   });
 });
@@ -318,8 +318,8 @@ describe("for a pre 2.7.0-beta.0 config without a workspace", () => {
   beforeEach(() => {
     ClusterStore.resetInstance();
     const mockOpts = {
-      'tmp': {
-        'lens-cluster-store.json': JSON.stringify({
+      "tmp": {
+        "lens-cluster-store.json": JSON.stringify({
           __internal__: {
             migrations: {
               version: "2.6.6"
@@ -345,7 +345,7 @@ describe("for a pre 2.7.0-beta.0 config without a workspace", () => {
 
   it("adds cluster to default workspace", async () => {
     const storedClusterData = clusterStore.clustersList[0];
-    expect(storedClusterData.workspace).toBe('default');
+    expect(storedClusterData.workspace).toBe("default");
   });
 });
 
@@ -353,8 +353,8 @@ describe("pre 3.6.0-beta.1 config with an existing cluster", () => {
   beforeEach(() => {
     ClusterStore.resetInstance();
     const mockOpts = {
-      'tmp': {
-        'lens-cluster-store.json': JSON.stringify({
+      "tmp": {
+        "lens-cluster-store.json": JSON.stringify({
           __internal__: {
             migrations: {
               version: "3.5.0"
@@ -362,9 +362,9 @@ describe("pre 3.6.0-beta.1 config with an existing cluster", () => {
           },
           clusters: [
             {
-              id: 'cluster1',
-              kubeConfig: 'kubeconfig content',
-              contextName: 'cluster',
+              id: "cluster1",
+              kubeConfig: "kubeconfig content",
+              contextName: "cluster",
               preferences: {
                 icon: "store://icon_path",
               }

src/common/__tests__/user-store.test.ts

@@ -3,9 +3,9 @@ import mockFs from "mock-fs";
 jest.mock("electron", () => {
   return {
     app: {
-      getVersion: () => '99.99.99',
-      getPath: () => 'tmp',
-      getLocale: () => 'en'
+      getVersion: () => "99.99.99",
+      getPath: () => "tmp",
+      getLocale: () => "en"
     }
   };
 });
@@ -18,7 +18,7 @@ describe("user store tests", () => {
   describe("for an empty config", () => {
     beforeEach(() => {
       UserStore.resetInstance();
-      mockFs({ tmp: { 'config.json': "{}" } });
+      mockFs({ tmp: { "config.json": "{}" } });
     });
 
     afterEach(() => {
@@ -35,26 +35,26 @@ describe("user store tests", () => {
     it("allows adding and listing seen contexts", () => {
       const us = UserStore.getInstance<UserStore>();
 
-      us.seenContexts.add('foo');
+      us.seenContexts.add("foo");
       expect(us.seenContexts.size).toBe(1);
 
-      us.seenContexts.add('foo');
-      us.seenContexts.add('bar');
+      us.seenContexts.add("foo");
+      us.seenContexts.add("bar");
       expect(us.seenContexts.size).toBe(2); // check 'foo' isn't added twice
-      expect(us.seenContexts.has('foo')).toBe(true);
-      expect(us.seenContexts.has('bar')).toBe(true);
+      expect(us.seenContexts.has("foo")).toBe(true);
+      expect(us.seenContexts.has("bar")).toBe(true);
     });
 
     it("allows setting and getting preferences", () => {
       const us = UserStore.getInstance<UserStore>();
 
-      us.preferences.httpsProxy = 'abcd://defg';
+      us.preferences.httpsProxy = "abcd://defg";
 
-      expect(us.preferences.httpsProxy).toBe('abcd://defg');
+      expect(us.preferences.httpsProxy).toBe("abcd://defg");
       expect(us.preferences.colorTheme).toBe(UserStore.defaultTheme);
 
       us.preferences.colorTheme = "light";
-      expect(us.preferences.colorTheme).toBe('light');
+      expect(us.preferences.colorTheme).toBe("light");
     });
 
     it("correctly resets theme to default value", async () => {
@@ -80,11 +80,11 @@ describe("user store tests", () => {
     beforeEach(() => {
       UserStore.resetInstance();
       mockFs({
-        'tmp': {
-          'config.json': JSON.stringify({
-            user: { username: 'foobar' },
-            preferences: { colorTheme: 'light' },
-            lastSeenAppVersion: '1.2.3'
+        "tmp": {
+          "config.json": JSON.stringify({
+            user: { username: "foobar" },
+            preferences: { colorTheme: "light" },
+            lastSeenAppVersion: "1.2.3"
           })
         }
       });
@@ -97,7 +97,7 @@ describe("user store tests", () => {
     it("sets last seen app version to 0.0.0", () => {
       const us = UserStore.getInstance<UserStore>();
 
-      expect(us.lastSeenAppVersion).toBe('0.0.0');
+      expect(us.lastSeenAppVersion).toBe("0.0.0");
     });
   });
 });

src/common/__tests__/workspace-store.test.ts

@@ -3,9 +3,9 @@ import mockFs from "mock-fs";
 jest.mock("electron", () => {
   return {
     app: {
-      getVersion: () => '99.99.99',
-      getPath: () => 'tmp',
-      getLocale: () => 'en'
+      getVersion: () => "99.99.99",
+      getPath: () => "tmp",
+      getLocale: () => "en"
     }
   };
 });
@@ -16,7 +16,7 @@ describe("workspace store tests", () => {
   describe("for an empty config", () => {
     beforeEach(async () => {
       WorkspaceStore.resetInstance();
-      mockFs({ tmp: { 'lens-workspace-store.json': "{}" } });
+      mockFs({ tmp: { "lens-workspace-store.json": "{}" } });
 
       await WorkspaceStore.getInstance<WorkspaceStore>().load();
     });
@@ -146,7 +146,7 @@ describe("workspace store tests", () => {
       WorkspaceStore.resetInstance();
       mockFs({
         tmp: {
-          'lens-workspace-store.json': JSON.stringify({
+          "lens-workspace-store.json": JSON.stringify({
             currentWorkspace: "abc",
             workspaces: [{
               id: "abc",

src/common/base-store.ts

@@ -2,7 +2,7 @@ import path from "path";
 import Config from "conf";
 import { Options as ConfOptions } from "conf/dist/source/types";
 import { app, ipcMain, IpcMainEvent, ipcRenderer, IpcRendererEvent, remote } from "electron";
-import { action, IReactionOptions, observable, reaction, runInAction, toJS, when } from "mobx";
+import { IReactionOptions, observable, reaction, runInAction, when } from "mobx";
 import Singleton from "./utils/singleton";
 import { getAppVersion } from "./utils/app-version";
 import logger from "../main/logger";

src/common/ipc.ts

@@ -16,7 +16,7 @@ export async function requestMain(channel: string, ...args: any[]) {
 
 async function getSubFrames(): Promise<number[]> {
   const subFrames: number[] = [];
-  clusterFrameMap.forEach((frameId, _) => {
+  clusterFrameMap.forEach(frameId => {
     subFrames.push(frameId);
   });
   return subFrames;

src/common/kube-helpers.ts

@@ -7,7 +7,7 @@ import logger from "../main/logger";
 import commandExists from "command-exists";
 import { ExecValidationNotFoundError } from "./custom-errors";
 
-export const kubeConfigDefaultPath = path.join(os.homedir(), '.kube', 'config');
+export const kubeConfigDefaultPath = path.join(os.homedir(), ".kube", "config");
 
 function resolveTilde(filePath: string) {
   if (filePath[0] === "~" && (filePath[1] === "/" || filePath.length === 1)) {
@@ -78,15 +78,15 @@ export function dumpConfigYaml(kubeConfig: Partial<KubeConfig>): string {
     apiVersion: "v1",
     kind: "Config",
     preferences: {},
-    'current-context': kubeConfig.currentContext,
+    "current-context": kubeConfig.currentContext,
     clusters: kubeConfig.clusters.map(cluster => {
       return {
         name: cluster.name,
         cluster: {
-          'certificate-authority-data': cluster.caData,
-          'certificate-authority': cluster.caFile,
+          "certificate-authority-data": cluster.caData,
+          "certificate-authority": cluster.caFile,
           server: cluster.server,
-          'insecure-skip-tls-verify': cluster.skipTLSVerify
+          "insecure-skip-tls-verify": cluster.skipTLSVerify
         }
       };
     }),
@@ -104,11 +104,11 @@ export function dumpConfigYaml(kubeConfig: Partial<KubeConfig>): string {
       return {
         name: user.name,
         user: {
-          'client-certificate-data': user.certData,
-          'client-certificate': user.certFile,
-          'client-key-data': user.keyData,
-          'client-key': user.keyFile,
-          'auth-provider': user.authProvider,
+          "client-certificate-data": user.certData,
+          "client-certificate": user.certFile,
+          "client-key-data": user.keyData,
+          "client-key": user.keyFile,
+          "auth-provider": user.authProvider,
           exec: user.exec,
           token: user.token,
           username: user.username,

src/common/user-store.ts

@@ -1,5 +1,5 @@
 import type { ThemeId } from "../renderer/theme.store";
-import { app, remote } from 'electron';
+import { app, remote } from "electron";
 import semver from "semver";
 import { readFile } from "fs-extra";
 import { action, observable, reaction, toJS } from "mobx";
@@ -9,7 +9,7 @@ import { getAppVersion } from "./utils/app-version";
 import { kubeConfigDefaultPath, loadConfig } from "./kube-helpers";
 import { appEventBus } from "./event-bus";
 import logger from "../main/logger";
-import path from 'path';
+import path from "path";
 
 export interface UserStoreModel {
   kubeConfigPath: string;

src/common/utils/debouncePromise.ts

@@ -2,7 +2,7 @@
 
 export function debouncePromise<T, F extends any[]>(func: (...args: F) => T | Promise<T>, timeout = 0): (...args: F) => Promise<T> {
   let timer: NodeJS.Timeout;
-  return (...params: any[]) => new Promise((resolve, reject) => {
+  return (...params: any[]) => new Promise(resolve => {
     clearTimeout(timer);
     timer = global.setTimeout(() => resolve(func.apply(this, params)), timeout);
   });

src/common/utils/escapeRegExp.ts

@@ -1,5 +1,5 @@
 // Helper to sanitize / escape special chars for passing to RegExp-constructor
 
 export function escapeRegExp(str: string) {
-  return str.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'); // $& means the whole matched string
+  return str.replace(/[.*+?^${}()|[\]\\]/g, "\\$&"); // $& means the whole matched string
 }