add no-unused and react/recommended to eslint (#1523)

* add no-unused-vars and no-unused-imports

* added quotes: double, and remove ignore pattern

* move itif and describeif into utils

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/renderer/components/+cluster-settings/components/cluster-accessible-namespaces.tsx

@@ -19,7 +19,7 @@ export class ClusterAccessibleNamespaces extends React.Component<Props> {
     return (
       <>
         <SubTitle title="Accessible Namespaces" />
-        <p><Trans>This setting is useful for manually specifying which namespaces you have access to. This is useful when you don't have permissions to list namespaces.</Trans></p>
+        <p><Trans>This setting is useful for manually specifying which namespaces you have access to. This is useful when you don&apos;t have permissions to list namespaces.</Trans></p>
         <EditableList
           placeholder={_i18n._("Add new namespace...")}
           add={(newNamespace) => {

src/renderer/components/+cluster-settings/components/cluster-icon-setting.tsx

@@ -28,7 +28,7 @@ export class ClusterIconSetting extends React.Component<Props> {
     try {
       if (file) {
         const buf = Buffer.from(await file.arrayBuffer());
-        cluster.preferences.icon = `data:${file.type};base64,${buf.toString('base64')}`;
+        cluster.preferences.icon = `data:${file.type};base64,${buf.toString("base64")}`;
       } else {
         // this has to be done as a seperate branch (and not always) because `cluster`
         // is observable and triggers an update loop.

src/renderer/components/+cluster-settings/components/cluster-prometheus-setting.tsx

@@ -78,7 +78,7 @@ export class ClusterPrometheusSetting extends React.Component<Props> {
         <SubTitle title="Prometheus"/>
         <p>
           Use pre-installed Prometheus service for metrics. Please refer to the{" "}
-          <a href="https://github.com/lensapp/lens/blob/master/troubleshooting/custom-prometheus.md" target="_blank">guide</a>{" "}
+          <a href="https://github.com/lensapp/lens/blob/master/troubleshooting/custom-prometheus.md" target="_blank" rel="noreferrer">guide</a>{" "}
           for possible configuration changes.
         </p>
         <p>Prometheus installation method.</p>
@@ -103,11 +103,11 @@ export class ClusterPrometheusSetting extends React.Component<Props> {
             />
             <small className="hint">
               An address to an existing Prometheus installation{" "}
-              ({'<namespace>/<service>:<port>'}). Lens tries to auto-detect address if left empty.
+              ({"<namespace>/<service>:<port>"}). Lens tries to auto-detect address if left empty.
             </small>
           </>
         )}
       </>
     );
   }
-}
+}

src/renderer/components/+cluster-settings/features.tsx

@@ -14,16 +14,18 @@ export class Features extends React.Component<Props> {
     return (
       <div>
         <h2>Features</h2>
-        { clusterFeatureRegistry.getItems().map((f) => {
-          return (
-            <InstallFeature cluster={cluster} feature={f.feature}>
-              <>
-                <SubTitle title={f.title}/>
-                <p><f.components.Description /></p>
-              </>
-            </InstallFeature>
-          );
-        })}
+        {
+          clusterFeatureRegistry
+            .getItems()
+            .map((f) => (
+              <InstallFeature key={f.title} cluster={cluster} feature={f.feature}>
+                <>
+                  <SubTitle title={f.title} />
+                  <p><f.components.Description /></p>
+                </>
+              </InstallFeature>
+            ))
+        }
       </div>
     );
   }