From 7bccc97da21499332009f5320b3b7518e433c797 Mon Sep 17 00:00:00 2001 From: Jari Kolehmainen Date: Tue, 24 Jan 2023 16:15:29 +0200 Subject: [PATCH] fix build:app on windows Signed-off-by: Jari Kolehmainen --- .github/workflows/test.yml | 6 +++--- packages/open-lens/package.json | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 697c82bbfd..153575366c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -69,18 +69,18 @@ jobs: minikube-version: latest if: ${{ runner.os == 'Linux' && matrix.type == 'smoke' }} - - run: xvfb-run --auto-servernum --server-args='-screen 0, 1600x900x24' make integration + - run: xvfb-run --auto-servernum --server-args='-screen 0, 1600x900x24' yarn run test:integration -- -- $ELECTRON_BUILDER_EXTRA_ARGS name: Run Linux integration tests if: ${{ runner.os == 'Linux' && matrix.type == 'smoke' }} - - run: yarn run test:integration + - run: yarn run test:integration -- -- $ELECTRON_BUILDER_EXTRA_ARGS name: Run macOS integration tests shell: bash env: ELECTRON_BUILDER_EXTRA_ARGS: "--x64 --arm64" if: ${{ runner.os == 'macOS' && matrix.type == 'smoke' }} - - run: yarn run test:integration + - run: yarn run test:integration -- -- $ELECTRON_BUILDER_EXTRA_ARGS name: Run Windows integration tests shell: bash env: diff --git a/packages/open-lens/package.json b/packages/open-lens/package.json index 1d246162ac..d162a8e759 100644 --- a/packages/open-lens/package.json +++ b/packages/open-lens/package.json @@ -21,7 +21,7 @@ "clean": "rm -rf binaries/ dist/ static/build", "build": "npm run compile", "postbuild": "npm run build:tray-icons && npm run download:binaries", - "build:app": "electron-builder --publish onTag $ELECTRON_BUILDER_EXTRA_ARGS", + "build:app": "electron-builder --publish onTag", "prebuild:app": "run-script-os", "prebuild:app:default": "exit 0", "prebuild:app:win32": "rm -rf node_modules/win-ca/pem",