From 7c80ea33e441d310d442ed823a2b49143cf0aa6c Mon Sep 17 00:00:00 2001
From: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Date: Mon, 27 Sep 2021 08:12:23 +0300
Subject: [PATCH] refactor deprecated window event handler

Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
---
 src/main/window-manager.ts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/main/window-manager.ts b/src/main/window-manager.ts
index 80e3224fd4..f751d79790 100644
--- a/src/main/window-manager.ts
+++ b/src/main/window-manager.ts
@@ -109,10 +109,6 @@ export class WindowManager extends Singleton {
           app.dock?.hide(); // hide icon in dock (mac-os)
         })
         .webContents
-        .on("new-window", (event, url) => {
-          event.preventDefault();
-          shell.openExternal(url);
-        })
         .on("dom-ready", () => {
           appEventBus.emit({ name: "app", action: "dom-ready" });
         })
@@ -150,6 +146,10 @@ export class WindowManager extends Singleton {
 
           // Always disable Node.js integration for all webviews
           webPreferences.nodeIntegration = false;
+        }).setWindowOpenHandler((details) => {
+          shell.openExternal(details.url);
+
+          return { action: "deny" };
         });
     }