Handle failing download of update

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

src/main/update-app/check-for-updates-tray-item.injectable.ts

@@ -53,7 +53,14 @@ const checkForUpdatesTrayItemInjectable = getInjectable({
           showNotification(`Download for version ${version} started...`);
 
           // Note: intentional orphan promise to make download happen in the background
-          versionUpdate.downloadUpdate().then(async () => {
+          versionUpdate.downloadUpdate().then(async ({ downloadWasSuccessful }) => {
+
+            if (!downloadWasSuccessful) {
+              showNotification(`Download for update failed`);
+
+              return;
+            }
+
             const userWantsToInstallUpdate = await askBoolean(`Do you want to install update ${version}?`);
 
             if (userWantsToInstallUpdate) {

src/main/update-app/version-update.injectable.ts

@@ -55,6 +55,7 @@ const versionUpdateInjectable = getInjectable({
       downloadUpdate: downloadUpdateFor(
         downloadPlatformUpdate,
         downloadingUpdateState,
+        discoveredVersionState,
       ),
     };
   },
@@ -66,17 +67,24 @@ const downloadUpdateFor =
   (
     downloadPlatformUpdate: () => Promise<{ downloadWasSuccessful: boolean }>,
     downloadingUpdateState: SyncBox<boolean>,
+    discoveredVersionState: SyncBox<{ version: string; updateChannel: UpdateChannel }>,
   ) =>
     async () => {
       runInAction(() => {
         downloadingUpdateState.set(true);
       });
 
-      await downloadPlatformUpdate();
+      const { downloadWasSuccessful } = await downloadPlatformUpdate();
 
       runInAction(() => {
+        if (!downloadWasSuccessful) {
+          discoveredVersionState.set(null);
+        }
+
         downloadingUpdateState.set(false);
       });
+
+      return { downloadWasSuccessful };
     };
 
 const checkForUpdatesFor =