Persist apiVersion when editing resources in monaco (#4406)

* Persist apiVersion when editing resources in monaco - Use a new custom k8slens prefixed label - Means that users aren't surprised when they use lens to update a resource to a new apiVersionWithGroup - Doesn't touch the versions in the stores Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix lint Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix: Fix lint issues Signed-off-by: Sebastian Malton <sebastian@malton.name> * chore: make lint not bail on failure Signed-off-by: Sebastian Malton <sebastian@malton.name> * chore: Run lint:fix on all files Signed-off-by: Sebastian Malton <sebastian@malton.name> --------- Signed-off-by: Sebastian Malton <sebastian@malton.name>
2025-05-20 05:10:56 +00:00 · 2023-04-05 10:56:23 -04:00
1 parent 058494bc73
commit 807f98ed1b
@@ -21,15 +21,9 @@ export {
  getMessageChannelListenerInjectable,
 } from "./message/message-channel-listener-injection-token";

-export type {
-  RequestChannel,
-  RequestChannelHandler,
-} from "./request/request-channel-listener-injection-token";
+export type { RequestChannel, RequestChannelHandler } from "./request/request-channel-listener-injection-token";

-export type {
-  RequestFromChannel,
-  ChannelRequester,
-} from "./request/request-from-channel-injection-token";
+export type { RequestFromChannel, ChannelRequester } from "./request/request-from-channel-injection-token";

 export type { EnlistMessageChannelListener } from "./message/enlist-message-channel-listener-injection-token";
 export { enlistMessageChannelListenerInjectionToken } from "./message/enlist-message-channel-listener-injection-token";
@@ -21,9 +21,7 @@ export const listeningOfChannelsInjectionToken = getInjectionToken<ListeningOfCh
  id: "listening-of-channels-injection-token",
 });

-const listening = <
-  T extends { id: string; channel: MessageChannel<any> | RequestChannel<any, any> },
->(
+const listening = <T extends { id: string; channel: MessageChannel<any> | RequestChannel<any, any> }>(
  channelListeners: IComputedValue<T[]>,
  enlistChannelListener: (listener: T) => () => void,
  getId: (listener: T) => string,
@@ -33,9 +31,7 @@ const listening = <
  const reactionDisposer = reaction(
    () => channelListeners.get(),
    (newValues, oldValues = []) => {
-      const addedListeners = newValues.filter(
-        (newValue) => !oldValues.some((oldValue) => oldValue.id === newValue.id),
-      );
+      const addedListeners = newValues.filter((newValue) => !oldValues.some((oldValue) => oldValue.id === newValue.id));

      const removedListeners = oldValues.filter(
        (oldValue) => !newValues.some((newValue) => newValue.id === oldValue.id),
@@ -45,9 +41,7 @@ const listening = <
        const id = getId(listener);

        if (listenerDisposers.has(id)) {
-          throw new Error(
-            `Tried to add listener for channel "${listener.channel.id}" but listener already exists.`,
-          );
+          throw new Error(`Tried to add listener for channel "${listener.channel.id}" but listener already exists.`);
        }

        const disposer = enlistChannelListener(listener);
@@ -1,16 +1,10 @@
 import type { Disposer } from "@k8slens/utilities";
 import { getInjectionToken } from "@ogre-tools/injectable";

-import type {
-  MessageChannel,
-  MessageChannelListener,
-} from "./message-channel-listener-injection-token";
+import type { MessageChannel, MessageChannelListener } from "./message-channel-listener-injection-token";

-export type EnlistMessageChannelListener = <T>(
-  listener: MessageChannelListener<MessageChannel<T>>,
-) => Disposer;
+export type EnlistMessageChannelListener = <T>(listener: MessageChannelListener<MessageChannel<T>>) => Disposer;

-export const enlistMessageChannelListenerInjectionToken =
-  getInjectionToken<EnlistMessageChannelListener>({
-    id: "listening-to-a-message-channel",
-  });
+export const enlistMessageChannelListenerInjectionToken = getInjectionToken<EnlistMessageChannelListener>({
+  id: "listening-to-a-message-channel",
+});
@@ -18,9 +18,7 @@ export interface MessageChannelListener<Channel> {
  handler: MessageChannelHandler<Channel>;
 }

-export const messageChannelListenerInjectionToken = getInjectionToken<
-  MessageChannelListener<MessageChannel<unknown>>
->({
+export const messageChannelListenerInjectionToken = getInjectionToken<MessageChannelListener<MessageChannel<unknown>>>({
  id: "message-channel-listener",
 });

@@ -31,10 +29,7 @@ export interface GetMessageChannelListenerInfo<Channel extends MessageChannel<Me
  causesSideEffects?: boolean;
 }

-export const getMessageChannelListenerInjectable = <
-  Channel extends MessageChannel<Message>,
-  Message,
->(
+export const getMessageChannelListenerInjectable = <Channel extends MessageChannel<Message>, Message>(
  info: GetMessageChannelListenerInfo<Channel, Message>,
 ) =>
  getInjectable({
@@ -1,16 +1,12 @@
 import type { Disposer } from "@k8slens/utilities/index";
 import { getInjectionToken } from "@ogre-tools/injectable";

-import type {
-  RequestChannel,
-  RequestChannelListener,
-} from "./request-channel-listener-injection-token";
+import type { RequestChannel, RequestChannelListener } from "./request-channel-listener-injection-token";

 export type EnlistRequestChannelListener = <Request, Response>(
  listener: RequestChannelListener<RequestChannel<Request, Response>>,
 ) => Disposer;

-export const enlistRequestChannelListenerInjectionToken =
-  getInjectionToken<EnlistRequestChannelListener>({
-    id: "listening-to-a-request-channel",
-  });
+export const enlistRequestChannelListenerInjectionToken = getInjectionToken<EnlistRequestChannelListener>({
+  id: "listening-to-a-request-channel",
+});
@@ -1,7 +1,5 @@
 import type { RequestChannel } from "./request-channel-listener-injection-token";

-export const getRequestChannel = <Request, Response>(
-  id: string,
-): RequestChannel<Request, Response> => ({
+export const getRequestChannel = <Request, Response>(id: string): RequestChannel<Request, Response> => ({
  id,
 });
@@ -7,10 +7,7 @@ export interface RequestChannel<Request, Response> {
  _responseSignature?: Response;
 }

-export type RequestChannelHandler<Channel> = Channel extends RequestChannel<
-  infer Request,
-  infer Response
->
+export type RequestChannelHandler<Channel> = Channel extends RequestChannel<infer Request, infer Response>
  ? (req: Request) => Promise<Response> | Response
  : never;

@@ -2,17 +2,11 @@ import { getInjectionToken } from "@ogre-tools/injectable";
 import type { RequestChannel } from "./request-channel-listener-injection-token";

 export interface RequestFromChannel {
-  <Request, Response>(
-    channel: RequestChannel<Request, Response>,
-    request: Request,
-  ): Promise<Response>;
+  <Request, Response>(channel: RequestChannel<Request, Response>, request: Request): Promise<Response>;
  <Response>(channel: RequestChannel<void, Response>): Promise<Response>;
 }

-export type ChannelRequester<Channel> = Channel extends RequestChannel<
-  infer Request,
-  infer Response
->
+export type ChannelRequester<Channel> = Channel extends RequestChannel<infer Request, infer Response>
  ? (req: Request) => Promise<Awaited<Response>>
  : never;

@@ -121,9 +121,7 @@ describe("listening-of-requests", () => {
            runInAction(() => {
              di.register(someConflictingListenerInjectable);
            });
-          }).toThrow(
-            'Tried to add listener for channel "some-channel-id" but listener already exists.',
-          );
+          }).toThrow('Tried to add listener for channel "some-channel-id" but listener already exists.');
        });

        describe("when another listener gets registered", () => {