From 81819dbbe9800985336871e11af3af387df5f03d Mon Sep 17 00:00:00 2001
From: Janne Savolainen <janne.savolainen@live.fi>
Date: Wed, 23 Feb 2022 13:26:14 +0200
Subject: [PATCH] Revert accidental breaking change in Extension API (#4904)

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
---
 src/common/k8s-api/kube-object.store.ts                  | 4 ++--
 .../components/+namespaces/add-namespace-dialog.tsx      | 9 +++++----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/common/k8s-api/kube-object.store.ts b/src/common/k8s-api/kube-object.store.ts
index 5eacc04888..373ffb8251 100644
--- a/src/common/k8s-api/kube-object.store.ts
+++ b/src/common/k8s-api/kube-object.store.ts
@@ -312,14 +312,14 @@ export abstract class KubeObjectStore<T extends KubeObject> extends ItemStore<T>
     return this.api.create(params, data);
   }
 
-  create = async (params: { name: string; namespace?: string }, data?: Partial<T>): Promise<T> => {
+  async create(params: { name: string; namespace?: string }, data?: Partial<T>): Promise<T> {
     const newItem = await this.createItem(params, data);
     const items = this.sortItems([...this.items, newItem]);
 
     this.items.replace(items);
 
     return newItem;
-  };
+  }
 
   private postUpdate(rawItem: KubeJsonApiData): T {
     const newItem = new this.api.objectConstructor(rawItem);
diff --git a/src/renderer/components/+namespaces/add-namespace-dialog.tsx b/src/renderer/components/+namespaces/add-namespace-dialog.tsx
index ee06c31876..406d4eec7a 100644
--- a/src/renderer/components/+namespaces/add-namespace-dialog.tsx
+++ b/src/renderer/components/+namespaces/add-namespace-dialog.tsx
@@ -19,6 +19,7 @@ import namespaceStoreInjectable from "./namespace-store/namespace-store.injectab
 import type { AddNamespaceDialogModel } from "./add-namespace-dialog-model/add-namespace-dialog-model";
 import addNamespaceDialogModelInjectable
   from "./add-namespace-dialog-model/add-namespace-dialog-model.injectable";
+import type { NamespaceStore } from "./namespace-store/namespace.store";
 
 interface Props extends DialogProps {
   onSuccess?(ns: Namespace): void;
@@ -26,7 +27,7 @@ interface Props extends DialogProps {
 }
 
 interface Dependencies {
-  createNamespace: (params: { name: string }) => Promise<Namespace>;
+  namespaceStore: NamespaceStore;
   model: AddNamespaceDialogModel;
 }
 
@@ -48,7 +49,7 @@ class NonInjectedAddNamespaceDialog extends React.Component<Props & Dependencies
     const { onSuccess, onError } = this.props;
 
     try {
-      const created = await this.props.createNamespace({ name: namespace });
+      const created = await this.props.namespaceStore.create({ name: namespace });
 
       onSuccess?.(created);
       this.props.model.close();
@@ -59,7 +60,7 @@ class NonInjectedAddNamespaceDialog extends React.Component<Props & Dependencies
   };
 
   render() {
-    const { model, createNamespace, ...dialogProps } = this.props;
+    const { model, namespaceStore, ...dialogProps } = this.props;
     const { namespace } = this;
     const header = <h5>Create Namespace</h5>;
 
@@ -97,7 +98,7 @@ export const AddNamespaceDialog = withInjectables<Dependencies, Props>(
 
   {
     getProps: (di, props) => ({
-      createNamespace: di.inject(namespaceStoreInjectable).create,
+      namespaceStore: di.inject(namespaceStoreInjectable),
       model: di.inject(addNamespaceDialogModelInjectable),
 
       ...props,