From 82aae2946cf30dabb6798c6a86b588136e0eadb7 Mon Sep 17 00:00:00 2001
From: Steve Richards <srichards@mirantis.com>
Date: Tue, 13 Oct 2020 16:36:43 +0100
Subject: [PATCH] Refactored logic to use a map

Signed-off-by: Steve Richards <srichards@mirantis.com>
---
 src/renderer/api/endpoints/ingress.api.ts | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/src/renderer/api/endpoints/ingress.api.ts b/src/renderer/api/endpoints/ingress.api.ts
index 68911fb882..8f81f3a05d 100644
--- a/src/renderer/api/endpoints/ingress.api.ts
+++ b/src/renderer/api/endpoints/ingress.api.ts
@@ -2,7 +2,6 @@ import { KubeObject } from "../kube-object";
 import { autobind } from "../../utils";
 import { IMetrics, metricsApi } from "./metrics.api";
 import { KubeApi } from "../kube-api";
-import { hostname } from "os";
 
 export class IngressApi extends KubeApi<Ingress> {
   getMetrics(ingress: string, namespace: string): Promise<IIngressMetrics> {
@@ -110,17 +109,11 @@ export class Ingress extends KubeObject {
   }
 
   getLoadBalancers() {
-    const ingressAddresses: string[] = [];
-    const { status: { loadBalancer } } = this;
-
-    if (!loadBalancer) return [];
-
-    loadBalancer.ingress.forEach(address => {
-      const entry = address.hostname ? address.hostname : address.ip;
-      ingressAddresses.push(entry); 
-    })
-
-    return ingressAddresses;
+    const { status: { loadBalancer = { ingress: [] } } } = this;
+    
+    return (loadBalancer.ingress ?? []).map(address => (
+      address.hostname || address.ip
+    ))
   }
 }