From 8349d6aa4a299009dd18c85950f89c97f5f59fde Mon Sep 17 00:00:00 2001 From: Alex Andreev Date: Thu, 16 Jun 2022 02:38:10 +0300 Subject: [PATCH] Fix html font size and adjust usage of rem units (#5641) * Leave default browser font-size for the html Signed-off-by: Alex Andreev * Fix preferences helm repos layout Signed-off-by: Alex Andreev * Adjust usage of rem units Signed-off-by: Alex Andreev * Adjust namespace select filter option sizes Signed-off-by: Alex Andreev * Fixing ToBottom btn sizing Signed-off-by: Alex Andreev * Fixing Remove Cluster dialog sizing Signed-off-by: Alex Andreev * Fixing catalog sidebar title font-size Signed-off-by: Alex Andreev * Fix Notice sizing Signed-off-by: Alex Andreev * Update snapshots Signed-off-by: Alex Andreev * Update more snapshots Signed-off-by: Alex Andreev --- ...elm-repository-in-preferences.test.ts.snap | 216 ++++++++-------- ...tory-from-list-in-preferences.test.ts.snap | 240 ++++++++++-------- ...m-repositories-in-preferences.test.ts.snap | 48 ++-- ...ive-repository-in-preferences.test.ts.snap | 48 ++-- .../+catalog/catalog-menu.module.scss | 7 +- .../components/+extensions/notice.module.scss | 6 +- .../+namespaces/namespace-select-filter.scss | 2 + .../helm-charts/helm-charts.module.scss | 14 +- .../helm-charts/helm-repositories.tsx | 12 +- .../+preferences/removable-item.module.scss | 5 +- src/renderer/components/app.scss | 3 + .../delete-cluster-dialog/view.module.scss | 20 +- .../components/delete-cluster-dialog/view.tsx | 2 +- .../components/dock/dock-tab.module.scss | 2 +- .../components/dock/logs/to-bottom.tsx | 2 +- .../layout/sidebar-cluster.module.scss | 7 +- .../layout/top-bar/top-bar.module.scss | 12 +- .../components/switch/switch.module.scss | 4 +- 18 files changed, 364 insertions(+), 286 deletions(-) diff --git a/src/behaviours/helm-charts/__snapshots__/add-custom-helm-repository-in-preferences.test.ts.snap b/src/behaviours/helm-charts/__snapshots__/add-custom-helm-repository-in-preferences.test.ts.snap index 89c9537585..21803cf04a 100644 --- a/src/behaviours/helm-charts/__snapshots__/add-custom-helm-repository-in-preferences.test.ts.snap +++ b/src/behaviours/helm-charts/__snapshots__/add-custom-helm-repository-in-preferences.test.ts.snap @@ -886,18 +886,20 @@ exports[`add custom helm repository in preferences when navigating to preference class="repos" >
-
- Some active repository -
-
- some-url +
+
+ Some active repository +
+
+ some-url +
-
- Some active repository -
-
- some-url +
+
+ Some active repository +
+
+ some-url +
-
- Some active repository -
-
- some-url +
+
+ Some active repository +
+
+ some-url +
-
- Some active repository -
-
- some-url +
+
+ Some active repository +
+
+ some-url +
-
- Some active repository -
-
- some-url +
+
+ Some active repository +
+
+ some-url +
-
- Some active repository -
-
- some-url +
+
+ Some active repository +
+
+ some-url +
-
- Some active repository -
-
- some-url +
+
+ Some active repository +
+
+ some-url +
-
- Some active repository -
-
- some-url +
+
+ Some active repository +
+
+ some-url +
-
- Some active repository -
-
- some-url +
+
+ Some active repository +
+
+ some-url +
-
- Some already active repository -
-
- some-url +
+
+ Some already active repository +
+
+ some-url +
-
- Some already active repository -
-
- some-url +
+
+ Some already active repository +
+
+ some-url +
-
- Some already active repository -
-
- some-url +
+
+ Some already active repository +
+
+ some-url +
-
- Some already active repository -
-
- some-url +
+
+ Some already active repository +
+
+ some-url +
-
- Some already active repository -
-
- some-url +
+
+ Some already active repository +
+
+ some-url +
-
- Some to be added repository -
-
- some-other-url +
+
+ Some to be added repository +
+
+ some-other-url +
-
- Some already active repository -
-
- some-url +
+
+ Some already active repository +
+
+ some-url +
-
- Some to be added repository -
-
- some-other-url +
+
+ Some to be added repository +
+
+ some-other-url +
-
- Some already active repository -
-
- some-url +
+
+ Some already active repository +
+
+ some-url +
-
- Some to be added repository -
-
- some-other-url +
+
+ Some to be added repository +
+
+ some-other-url +
-
- some-repository -
-
- some-repository-url +
+
+ some-repository +
+
+ some-repository-url +
-
- some-other-repository -
-
- some-other-repository-url +
+
+ some-other-repository +
+
+ some-other-repository-url +
-
- some-active-repository -
-
- some-url +
+
+ some-active-repository +
+
+ some-url +
-
- some-active-repository -
-
- some-url +
+
+ some-active-repository +
+
+ some-url +
removeRepository(repository)} - className="mt-3" + className={styles.repo} data-testid={`remove-helm-repository-${repository.name}`} > -
- {repository.name} -
+
+
+ {repository.name} +
-
{repository.url}
+
{repository.url}
+
))}
diff --git a/src/renderer/components/+preferences/removable-item.module.scss b/src/renderer/components/+preferences/removable-item.module.scss index e170da9532..6734dda5b9 100644 --- a/src/renderer/components/+preferences/removable-item.module.scss +++ b/src/renderer/components/+preferences/removable-item.module.scss @@ -1,7 +1,8 @@ .item { - --flex-gap: 1.2rem; + --flex-gap: 0.5rem; - @apply rounded-md px-7 py-5 shadow-sm; background: var(--inputControlBackground); min-height: 65px; + border-radius: 3px; + padding: calc(var(--padding) * 1.5); } \ No newline at end of file diff --git a/src/renderer/components/app.scss b/src/renderer/components/app.scss index 80317acb59..68cc6db3d9 100755 --- a/src/renderer/components/app.scss +++ b/src/renderer/components/app.scss @@ -68,6 +68,9 @@ html, body { height: 100%; overflow: hidden; +} + +body { color: var(--textColorPrimary); background-color: var(--mainBackground); font-size: var(--font-size); diff --git a/src/renderer/components/delete-cluster-dialog/view.module.scss b/src/renderer/components/delete-cluster-dialog/view.module.scss index 0c95c3d2a6..e8f513a991 100644 --- a/src/renderer/components/delete-cluster-dialog/view.module.scss +++ b/src/renderer/components/delete-cluster-dialog/view.module.scss @@ -1,17 +1,22 @@ .warning { - @apply mt-4 flex py-4 px-6 rounded-md items-center; + display: flex; + margin-top: var(--margin); + padding: calc(var(--padding) * 2) calc(var(--padding) * 3); + border-radius: 4px; + align-items: center; background: #fad8d7; color: #797979; } .warningIcon { - @apply mr-5; + margin-right: calc(var(--margin) * 2.4); font-size: 26px; } .dialog { > div { - @apply rounded-md bg-white; + border-radius: 4px; + background-color: white; max-width: 600px; min-width: calc(45 * var(--unit)); } @@ -22,11 +27,14 @@ } .dialogContent { - @apply p-9 leading-9; + padding: calc(var(--padding) * 2) calc(var(--padding) * 3); } .dialogButtons { - @apply flex justify-end p-7 rounded-md; + display: flex; + border-radius: 4px; + justify-content: flex-end; + padding: calc(var(--padding) * 2); background: #f4f4f4; > * { @@ -35,7 +43,7 @@ } .hr { - @apply mt-7; + margin-top: calc(var(--margin) * 3); height: 1px; background: #dfdfdf80; } \ No newline at end of file diff --git a/src/renderer/components/delete-cluster-dialog/view.tsx b/src/renderer/components/delete-cluster-dialog/view.tsx index 79e0ea88ee..3d86bae4a9 100644 --- a/src/renderer/components/delete-cluster-dialog/view.tsx +++ b/src/renderer/components/delete-cluster-dialog/view.tsx @@ -204,9 +204,9 @@ class NonInjectedDeleteClusterDialog extends React.Component {
{this.renderDeleteMessage(state)} {this.renderWarning(state)} -
{contexts.length > 0 && ( <> +
void }) { return (