From 840d3dcea801fbae6244e15e092fe437b076edc2 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Mon, 6 Mar 2023 15:38:38 -0500 Subject: [PATCH] Fix test - This was a side effect of the previous bug fixes where the clusterContext.hasAllSelected was previously erroneously 'false' Signed-off-by: Sebastian Malton --- .../installing-helm-chart-from-new-tab.test.ts | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/core/src/features/helm-charts/installing-chart/installing-helm-chart-from-new-tab.test.ts b/packages/core/src/features/helm-charts/installing-chart/installing-helm-chart-from-new-tab.test.ts index f7aef8dd88..b63d08f904 100644 --- a/packages/core/src/features/helm-charts/installing-chart/installing-helm-chart-from-new-tab.test.ts +++ b/packages/core/src/features/helm-charts/installing-chart/installing-helm-chart-from-new-tab.test.ts @@ -28,6 +28,9 @@ import requestHelmChartReadmeInjectable from "../../../common/k8s-api/endpoints/ import requestHelmChartValuesInjectable from "../../../common/k8s-api/endpoints/helm-charts.api/request-values.injectable"; import type { RequestDetailedHelmRelease } from "../../../renderer/components/+helm-releases/release-details/release-details-model/request-detailed-helm-release.injectable"; import requestDetailedHelmReleaseInjectable from "../../../renderer/components/+helm-releases/release-details/release-details-model/request-detailed-helm-release.injectable"; +import type { RequestHelmReleases } from "../../../common/k8s-api/endpoints/helm-releases.api/request-releases.injectable"; +import requestHelmReleasesInjectable from "../../../common/k8s-api/endpoints/helm-releases.api/request-releases.injectable"; +import { flushPromises } from "../../../common/test-utils/flush-promises"; describe("installing helm chart from new tab", () => { let builder: ApplicationBuilder; @@ -37,6 +40,7 @@ describe("installing helm chart from new tab", () => { let requestHelmChartReadmeMock: AsyncFnMock; let requestHelmChartValuesMock: AsyncFnMock; let requestCreateHelmReleaseMock: AsyncFnMock; + let requestHelmReleasesMock: AsyncFnMock; beforeEach(() => { builder = getApplicationBuilder(); @@ -49,6 +53,7 @@ describe("installing helm chart from new tab", () => { requestHelmChartReadmeMock = asyncFn(); requestHelmChartValuesMock = asyncFn(); requestCreateHelmReleaseMock = asyncFn(); + requestHelmReleasesMock = asyncFn(); builder.beforeWindowStart((windowDi) => { windowDi.override(directoryForLensLocalStorageInjectable, () => "/some-directory-for-lens-local-storage"); @@ -58,6 +63,7 @@ describe("installing helm chart from new tab", () => { windowDi.override(requestHelmChartReadmeInjectable, () => requestHelmChartReadmeMock); windowDi.override(requestHelmChartValuesInjectable, () => requestHelmChartValuesMock); windowDi.override(requestCreateHelmReleaseInjectable, () => requestCreateHelmReleaseMock); + windowDi.override(requestHelmReleasesInjectable, () => requestHelmReleasesMock); windowDi.override(getRandomInstallChartTabIdInjectable, () => jest @@ -386,12 +392,15 @@ describe("installing helm chart from new tab", () => { }); describe("when selected to see the installed release", () => { - beforeEach(() => { + beforeEach(async () => { const releaseButton = rendered.getByTestId( "show-release-some-release-for-some-first-tab-id", ); fireEvent.click(releaseButton); + + await flushPromises(); + await requestHelmReleasesMock.resolve([]); }); it("renders", () => {