hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Choose better names for start-frame runnable tokens

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2022-12-14 09:00:09 -05:00
parent f43757e23b
commit 8416d965e7
8 changed files with 23 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/renderer/app-paths/setup-app-paths.injectable.ts
View File

@ -4,7 +4,7 @@
*/ */
import { getInjectable } from "@ogre-tools/injectable"; import { getInjectable } from "@ogre-tools/injectable";
import appPathsStateInjectable from "../../common/app-paths/app-paths-state.injectable"; import appPathsStateInjectable from "../../common/app-paths/app-paths-state.injectable";
import { evenBeforeFrameStartsInjectionToken } from "../before-frame-starts/tokens"; import { beforeFrameStartsFirstInjectionToken } from "../before-frame-starts/tokens";
import { appPathsChannel } from "../../common/app-paths/app-paths-channel"; import { appPathsChannel } from "../../common/app-paths/app-paths-channel";
import { requestFromChannelInjectionToken } from "../../common/utils/channel/request-from-channel-injection-token"; import { requestFromChannelInjectionToken } from "../../common/utils/channel/request-from-channel-injection-token";
@ -22,7 +22,7 @@ const setupAppPathsInjectable = getInjectable({
}, },
}), }),
injectionToken: evenBeforeFrameStartsInjectionToken, injectionToken: beforeFrameStartsFirstInjectionToken,
}); });
export default setupAppPathsInjectable; export default setupAppPathsInjectable;

4
src/renderer/before-frame-starts/runnables/configure-immer.injectable.ts
View File

@ -4,7 +4,7 @@
*/ */
import { getInjectable } from "@ogre-tools/injectable"; import { getInjectable } from "@ogre-tools/injectable";
import { setAutoFreeze, enableMapSet } from "immer"; import { setAutoFreeze, enableMapSet } from "immer";
import { evenBeforeFrameStartsInjectionToken } from "../tokens"; import { beforeFrameStartsFirstInjectionToken } from "../tokens";
const configureImmerInjectable = getInjectable({ const configureImmerInjectable = getInjectable({
id: "configure-immer", id: "configure-immer",
@ -17,7 +17,7 @@ const configureImmerInjectable = getInjectable({
enableMapSet(); // allow to merge maps and sets enableMapSet(); // allow to merge maps and sets
}, },
}), }),
injectionToken: evenBeforeFrameStartsInjectionToken, injectionToken: beforeFrameStartsFirstInjectionToken,
}); });
export default configureImmerInjectable; export default configureImmerInjectable;

4
src/renderer/before-frame-starts/runnables/configure-mobx.injectable.ts
View File

@ -4,7 +4,7 @@
*/ */
import { getInjectable } from "@ogre-tools/injectable"; import { getInjectable } from "@ogre-tools/injectable";
import { configure } from "mobx"; import { configure } from "mobx";
import { evenBeforeFrameStartsInjectionToken } from "../tokens"; import { beforeFrameStartsFirstInjectionToken } from "../tokens";
const configureMobxInjectable = getInjectable({ const configureMobxInjectable = getInjectable({
id: "configure-mobx", id: "configure-mobx",
@ -22,7 +22,7 @@ const configureMobxInjectable = getInjectable({
}); });
}, },
}), }),
injectionToken: evenBeforeFrameStartsInjectionToken, injectionToken: beforeFrameStartsFirstInjectionToken,
}); });
export default configureMobxInjectable; export default configureMobxInjectable;

4
src/renderer/before-frame-starts/runnables/setup-auto-registration.injectable.ts
View File

@ -9,7 +9,7 @@ import { CustomResourceStore } from "../../../common/k8s-api/api-manager/resourc
import type { CustomResourceDefinition } from "../../../common/k8s-api/endpoints"; import type { CustomResourceDefinition } from "../../../common/k8s-api/endpoints";
import { KubeApi } from "../../../common/k8s-api/kube-api"; import { KubeApi } from "../../../common/k8s-api/kube-api";
import { KubeObject } from "../../../common/k8s-api/kube-object"; import { KubeObject } from "../../../common/k8s-api/kube-object";
import { evenBeforeClusterFrameStartsInjectionToken } from "../tokens"; import { beforeClusterFrameStartsInjectionToken } from "../tokens";
const setupAutoRegistrationInjectable = getInjectable({ const setupAutoRegistrationInjectable = getInjectable({
id: "setup-auto-registration", id: "setup-auto-registration",
@ -73,7 +73,7 @@ const setupAutoRegistrationInjectable = getInjectable({
initialized = true; initialized = true;
}, },
}), }),
injectionToken: evenBeforeClusterFrameStartsInjectionToken, injectionToken: beforeClusterFrameStartsInjectionToken,
}); });
export default setupAutoRegistrationInjectable; export default setupAutoRegistrationInjectable;

4
src/renderer/before-frame-starts/runnables/setup-current-cluster-broadcast.injectable.ts
View File

@ -7,7 +7,7 @@ import { reaction } from "mobx";
import { currentClusterMessageChannel } from "../../../common/cluster/current-cluster-channel"; import { currentClusterMessageChannel } from "../../../common/cluster/current-cluster-channel";
import { sendMessageToChannelInjectionToken } from "../../../common/utils/channel/message-to-channel-injection-token"; import { sendMessageToChannelInjectionToken } from "../../../common/utils/channel/message-to-channel-injection-token";
import matchedClusterIdInjectable from "../../navigation/matched-cluster-id.injectable"; import matchedClusterIdInjectable from "../../navigation/matched-cluster-id.injectable";
import { evenBeforeMainFrameStartsInjectionToken } from "../tokens"; import { beforeMainFrameStartsInjectionToken } from "../tokens";
const setupCurrentClusterBroadcastInjectable = getInjectable({ const setupCurrentClusterBroadcastInjectable = getInjectable({
id: "setup-current-cluster-broadcast", id: "setup-current-cluster-broadcast",
@ -26,7 +26,7 @@ const setupCurrentClusterBroadcastInjectable = getInjectable({
); );
}, },
}), }),
injectionToken: evenBeforeMainFrameStartsInjectionToken, injectionToken: beforeMainFrameStartsInjectionToken,
}); });
export default setupCurrentClusterBroadcastInjectable; export default setupCurrentClusterBroadcastInjectable;

4
src/renderer/before-frame-starts/runnables/setup-sentry.injectable.ts
View File

@ -4,7 +4,7 @@
*/ */
import { getInjectable } from "@ogre-tools/injectable"; import { getInjectable } from "@ogre-tools/injectable";
import initializeSentryReportingWithInjectable from "../../../common/error-reporting/initialize-sentry-reporting.injectable"; import initializeSentryReportingWithInjectable from "../../../common/error-reporting/initialize-sentry-reporting.injectable";
import { evenBeforeMainFrameStartsInjectionToken } from "../tokens"; import { beforeMainFrameStartsInjectionToken } from "../tokens";
import { init } from "@sentry/electron/renderer"; import { init } from "@sentry/electron/renderer";
const setupSentryInjectable = getInjectable({ const setupSentryInjectable = getInjectable({
@ -17,7 +17,7 @@ const setupSentryInjectable = getInjectable({
initializeSentryReportingWith(init); initializeSentryReportingWith(init);
}, },
}), }),
injectionToken: evenBeforeMainFrameStartsInjectionToken, injectionToken: beforeMainFrameStartsInjectionToken,
}); });
export default setupSentryInjectable; export default setupSentryInjectable;

7
src/renderer/before-frame-starts/tokens.ts
View File

@ -5,17 +5,18 @@
import { getInjectionToken } from "@ogre-tools/injectable"; import { getInjectionToken } from "@ogre-tools/injectable";
import type { Runnable } from "../../common/runnable/run-many-for"; import type { Runnable } from "../../common/runnable/run-many-for";
export const evenBeforeFrameStartsInjectionToken = getInjectionToken<Runnable>({ // NOTE: these are run before any other token, mostly to set up things that all other runnables need
export const beforeFrameStartsFirstInjectionToken = getInjectionToken<Runnable>({
id: "even-before-frame-starts", id: "even-before-frame-starts",
}); });
// NOTE: these are only run when process.isMainFrame === true // NOTE: these are only run when process.isMainFrame === true
export const evenBeforeMainFrameStartsInjectionToken = getInjectionToken<Runnable>({ export const beforeMainFrameStartsInjectionToken = getInjectionToken<Runnable>({
id: "even-before-main-frame-starts", id: "even-before-main-frame-starts",
}); });
// NOTE: these are only run when process.isMainFrame === false // NOTE: these are only run when process.isMainFrame === false
export const evenBeforeClusterFrameStartsInjectionToken = getInjectionToken<Runnable>({ export const beforeClusterFrameStartsInjectionToken = getInjectionToken<Runnable>({
id: "even-before-cluster-frame-starts", id: "even-before-cluster-frame-starts",
}); });

14
src/renderer/start-frame/start-frame.injectable.ts
View File

@ -4,7 +4,7 @@
*/ */
import { getInjectable } from "@ogre-tools/injectable"; import { getInjectable } from "@ogre-tools/injectable";
import { runManyFor } from "../../common/runnable/run-many-for"; import { runManyFor } from "../../common/runnable/run-many-for";
import { beforeFrameStartsInjectionToken, evenBeforeClusterFrameStartsInjectionToken, evenBeforeFrameStartsInjectionToken, evenBeforeMainFrameStartsInjectionToken } from "../before-frame-starts/tokens"; import { beforeFrameStartsInjectionToken, beforeClusterFrameStartsInjectionToken, beforeFrameStartsFirstInjectionToken, beforeMainFrameStartsInjectionToken } from "../before-frame-starts/tokens";
import currentlyInClusterFrameInjectable from "../routes/currently-in-cluster-frame.injectable"; import currentlyInClusterFrameInjectable from "../routes/currently-in-cluster-frame.injectable";
const startFrameInjectable = getInjectable({ const startFrameInjectable = getInjectable({
@ -13,19 +13,19 @@ const startFrameInjectable = getInjectable({
// TODO: Consolidate contents of bootstrap.tsx here // TODO: Consolidate contents of bootstrap.tsx here
instantiate: (di) => { instantiate: (di) => {
const runMany = runManyFor(di); const runMany = runManyFor(di);
const evenBeforeFrameStarts = runMany(evenBeforeFrameStartsInjectionToken); const beforeFrameStartsFirst = runMany(beforeFrameStartsFirstInjectionToken);
const evenBeforeMainFrameStarts = runMany(evenBeforeMainFrameStartsInjectionToken); const beforeMainFrameStarts = runMany(beforeMainFrameStartsInjectionToken);
const evenBeforeClusterFrameStarts = runMany(evenBeforeClusterFrameStartsInjectionToken); const beforeClusterFrameStarts = runMany(beforeClusterFrameStartsInjectionToken);
const beforeFrameStarts = runMany(beforeFrameStartsInjectionToken); const beforeFrameStarts = runMany(beforeFrameStartsInjectionToken);
const currentlyInClusterFrame = di.inject(currentlyInClusterFrameInjectable); const currentlyInClusterFrame = di.inject(currentlyInClusterFrameInjectable);
return async () => { return async () => {
await evenBeforeFrameStarts(); await beforeFrameStartsFirst();
if (currentlyInClusterFrame) { if (currentlyInClusterFrame) {
await evenBeforeClusterFrameStarts(); await beforeClusterFrameStarts();
} else { } else {
await evenBeforeMainFrameStarts(); await beforeMainFrameStarts();
} }
await beforeFrameStarts(); await beforeFrameStarts();