Allow installing extensions by dist-tag (#3040)

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/renderer/components/+extensions/extensions.tsx

@@ -313,9 +313,13 @@ export async function attemptInstallByInfo({ name, version, requireConfirmation
 
   if (version) {
     if (!json.versions[version]) {
-      Notifications.error(<p>The <em>{name}</em> extension does not have a v{version}.</p>);
+      if (json["dist-tags"][version]) {
-
+        version = json["dist-tags"][version];
-      return disposer();
+      } else {
+        Notifications.error(<p>The <em>{name}</em> extension does not have a version or tag <code>{version}</code>.</p>);
+  
+        return disposer();
+      }
     }
   } else {
     const versions = Object.keys(json.versions)
@@ -490,18 +494,12 @@ export class Extensions extends React.Component<Props> {
   }
 
   componentDidMount() {
-    // TODO: change this after upgrading to mobx6 as that versions' reactions have this functionality
-    let prevSize = ExtensionLoader.getInstance().userExtensions.size;
-
     disposeOnUnmount(this, [
-      reaction(() => ExtensionLoader.getInstance().userExtensions.size, curSize => {
+      reaction(() => ExtensionLoader.getInstance().userExtensions.size, (curSize, prevSize) => {
-        try {
+        if (curSize > prevSize) {
-          if (curSize > prevSize) {
+          disposeOnUnmount(this, [
-            when(() => !ExtensionInstallationStateStore.anyInstalling)
+            when(() => !ExtensionInstallationStateStore.anyInstalling, () => this.installPath = ""),
-              .then(() => this.installPath = "");
+          ]);
-          }
-        } finally {
-          prevSize = curSize;
         }
       })
     ]);

src/renderer/components/input/input_validators.ts

@@ -68,7 +68,7 @@ export const isUrl: InputValidator = {
   },
 };
 
-export const isExtensionNameInstallRegex = /^(?<name>(@[-\w]+\/)?[-\w]+)(@(?<version>\d\.\d\.\d(-\w+)?))?$/gi;
+export const isExtensionNameInstallRegex = /^(?<name>(@[-\w]+\/)?[-\w]+)(@(?<version>[a-z0-9-_.]+))?$/gi;
 
 export const isExtensionNameInstall: InputValidator = {
   condition: ({ type }) => type === "text",