1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00

refactor with some bulletproofing

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
This commit is contained in:
Jim Ehrismann 2021-10-28 16:18:48 -04:00
parent 6d43dbb8eb
commit 856e1ad449

View File

@ -37,14 +37,15 @@ const Placeholder = observer((props: PlaceholderProps<any, boolean>) => {
const getPlaceholder = (): React.ReactNode => { const getPlaceholder = (): React.ReactNode => {
const namespaces = namespaceStore.contextNamespaces; const namespaces = namespaceStore.contextNamespaces;
switch (namespaceStore.selectedNamespaces.length) { if (!namespaceStore.selectedNamespaces.length || !namespaces.length) {
case 0: return <>All namespaces</>;
return <>All namespaces</>;
case 1:
return <>Namespace: {namespaces[0]}</>;
default:
return <>Namespaces: {namespaces.join(", ")}</>;
} }
if (namespaces.length === 1) {
return <>Namespace: {namespaces[0]}</>;
}
return <>Namespaces: {namespaces.join(", ")}</>;
}; };
return ( return (
@ -100,9 +101,9 @@ export class NamespaceSelectFilter extends React.Component<SelectProps> {
return ( return (
<div className="flex gaps align-center"> <div className="flex gaps align-center">
<Icon small material="layers"/> <Icon small material="layers" />
<span>{namespace}</span> <span>{namespace}</span>
{isSelected && <Icon small material="check" className="box right"/>} {isSelected && <Icon small material="check" className="box right" />}
</div> </div>
); );
} }