From 8634c3b56f9e38703f24aecb325c115140160a55 Mon Sep 17 00:00:00 2001
From: Juho Heikka <juho.heikka@gmail.com>
Date: Thu, 19 Jan 2023 18:47:20 +0200
Subject: [PATCH] Do not show Created on DetailsPane when there's no timestamp.
 (#6984)

---
 ...when-cluster-is-not-relevant.test.tsx.snap | 45 -------------------
 ...hide-kube-object-detail-item.test.tsx.snap | 30 -------------
 .../kube-object-meta/kube-object-meta.tsx     |  2 +-
 3 files changed, 1 insertion(+), 76 deletions(-)

diff --git a/src/features/cluster/kube-object-details/extension-api/__snapshots__/disable-kube-object-detail-items-when-cluster-is-not-relevant.test.tsx.snap b/src/features/cluster/kube-object-details/extension-api/__snapshots__/disable-kube-object-detail-items-when-cluster-is-not-relevant.test.tsx.snap
index 6a0943b664..71d807a43d 100644
--- a/src/features/cluster/kube-object-details/extension-api/__snapshots__/disable-kube-object-detail-items-when-cluster-is-not-relevant.test.tsx.snap
+++ b/src/features/cluster/kube-object-details/extension-api/__snapshots__/disable-kube-object-detail-items-when-cluster-is-not-relevant.test.tsx.snap
@@ -54,21 +54,6 @@ exports[`disable kube object detail items when cluster is not relevant given ext
         <div
           class="drawer-content flex column box grow"
         >
-          <div
-            class="DrawerItem"
-          >
-            <span
-              class="name"
-            >
-              Created
-            </span>
-            <span
-              class="value"
-            >
-              &lt;unknown&gt;
-               ago 
-            </span>
-          </div>
           <div
             class="DrawerItem"
           >
@@ -685,21 +670,6 @@ exports[`disable kube object detail items when cluster is not relevant given ext
         <div
           class="drawer-content flex column box grow"
         >
-          <div
-            class="DrawerItem"
-          >
-            <span
-              class="name"
-            >
-              Created
-            </span>
-            <span
-              class="value"
-            >
-              &lt;unknown&gt;
-               ago 
-            </span>
-          </div>
           <div
             class="DrawerItem"
           >
@@ -1311,21 +1281,6 @@ exports[`disable kube object detail items when cluster is not relevant given not
         <div
           class="drawer-content flex column box grow"
         >
-          <div
-            class="DrawerItem"
-          >
-            <span
-              class="name"
-            >
-              Created
-            </span>
-            <span
-              class="value"
-            >
-              &lt;unknown&gt;
-               ago 
-            </span>
-          </div>
           <div
             class="DrawerItem"
           >
diff --git a/src/features/cluster/kube-object-details/extension-api/__snapshots__/reactively-hide-kube-object-detail-item.test.tsx.snap b/src/features/cluster/kube-object-details/extension-api/__snapshots__/reactively-hide-kube-object-detail-item.test.tsx.snap
index 578fcae9e9..9222e8a538 100644
--- a/src/features/cluster/kube-object-details/extension-api/__snapshots__/reactively-hide-kube-object-detail-item.test.tsx.snap
+++ b/src/features/cluster/kube-object-details/extension-api/__snapshots__/reactively-hide-kube-object-detail-item.test.tsx.snap
@@ -54,21 +54,6 @@ exports[`reactively hide kube object detail item renders 1`] = `
         <div
           class="drawer-content flex column box grow"
         >
-          <div
-            class="DrawerItem"
-          >
-            <span
-              class="name"
-            >
-              Created
-            </span>
-            <span
-              class="value"
-            >
-              &lt;unknown&gt;
-               ago 
-            </span>
-          </div>
           <div
             class="DrawerItem"
           >
@@ -680,21 +665,6 @@ exports[`reactively hide kube object detail item when the item is shown renders
         <div
           class="drawer-content flex column box grow"
         >
-          <div
-            class="DrawerItem"
-          >
-            <span
-              class="name"
-            >
-              Created
-            </span>
-            <span
-              class="value"
-            >
-              &lt;unknown&gt;
-               ago 
-            </span>
-          </div>
           <div
             class="DrawerItem"
           >
diff --git a/src/renderer/components/kube-object-meta/kube-object-meta.tsx b/src/renderer/components/kube-object-meta/kube-object-meta.tsx
index 593f2cb2ae..a61ee7dd60 100644
--- a/src/renderer/components/kube-object-meta/kube-object-meta.tsx
+++ b/src/renderer/components/kube-object-meta/kube-object-meta.tsx
@@ -62,7 +62,7 @@ const NonInjectedKubeObjectMeta = observer(({
 
   return (
     <>
-      <DrawerItem name="Created" hidden={isHidden("creationTimestamp")}>
+      <DrawerItem name="Created" hidden={isHidden("creationTimestamp") || !creationTimestamp}>
         <KubeObjectAge object={object} compact={false} />
         {" ago "}
         {creationTimestamp && <LocaleDate date={creationTimestamp} />}