From 8a02c5c0e0007a978b42116df76ca5f9f790c1ba Mon Sep 17 00:00:00 2001
From: Alex Andreev <alex.andreev.email@gmail.com>
Date: Tue, 28 Dec 2021 08:10:36 +0300
Subject: [PATCH] Fix fetching values from onChange callback

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
---
 src/renderer/components/+preferences/application.tsx      | 7 +++++--
 src/renderer/components/+preferences/editor.tsx           | 5 ++++-
 src/renderer/components/+preferences/kubectl-binaries.tsx | 5 ++++-
 src/renderer/components/+preferences/proxy.tsx            | 3 ++-
 src/renderer/components/switch/switch.tsx                 | 1 -
 5 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/src/renderer/components/+preferences/application.tsx b/src/renderer/components/+preferences/application.tsx
index 07607faca9..1e3c75b68f 100644
--- a/src/renderer/components/+preferences/application.tsx
+++ b/src/renderer/components/+preferences/application.tsx
@@ -86,7 +86,10 @@ export const Application = observer(() => {
 
       <section id="terminalSelection">
         <SubTitle title="Terminal copy & paste" />
-        <Switch checked={userStore.terminalCopyOnSelect} onChange={v => userStore.terminalCopyOnSelect = v.target.checked}>
+        <Switch
+          checked={userStore.terminalCopyOnSelect}
+          onChange={() => userStore.terminalCopyOnSelect = !userStore.terminalCopyOnSelect}
+        >
           Copy on select and paste on right-click
         </Switch>
       </section>
@@ -128,7 +131,7 @@ export const Application = observer(() => {
 
       <section id="other">
         <SubTitle title="Start-up"/>
-        <Switch checked={userStore.openAtLogin} onChange={v => userStore.openAtLogin = v.target.checked}>
+        <Switch checked={userStore.openAtLogin} onChange={() => userStore.openAtLogin = !userStore.openAtLogin}>
           Automatically start Lens on login
         </Switch>
       </section>
diff --git a/src/renderer/components/+preferences/editor.tsx b/src/renderer/components/+preferences/editor.tsx
index bea1b4524e..f1491f919e 100644
--- a/src/renderer/components/+preferences/editor.tsx
+++ b/src/renderer/components/+preferences/editor.tsx
@@ -45,7 +45,10 @@ export const Editor = observer(() => {
       <section>
         <div className="flex gaps justify-space-between">
           <div className="flex gaps align-center">
-            <Switch checked={editorConfiguration.minimap.enabled} onChange={v => editorConfiguration.minimap.enabled = v.target.checked}>
+            <Switch
+              checked={editorConfiguration.minimap.enabled}
+              onChange={() => editorConfiguration.minimap.enabled = !editorConfiguration.minimap.enabled}
+            >
               Copy on select and paste on right-click
             </Switch>
           </div>
diff --git a/src/renderer/components/+preferences/kubectl-binaries.tsx b/src/renderer/components/+preferences/kubectl-binaries.tsx
index b63f03fb06..13a0299ee3 100644
--- a/src/renderer/components/+preferences/kubectl-binaries.tsx
+++ b/src/renderer/components/+preferences/kubectl-binaries.tsx
@@ -48,7 +48,10 @@ export const KubectlBinaries = observer(() => {
     <>
       <section>
         <SubTitle title="Kubectl binary download"/>
-        <Switch checked={userStore.downloadKubectlBinaries} onChange={v => userStore.downloadKubectlBinaries = v.target.checked}>
+        <Switch
+          checked={userStore.downloadKubectlBinaries}
+          onChange={() => userStore.downloadKubectlBinaries = !userStore.downloadKubectlBinaries}
+        >
           Download kubectl binaries matching the Kubernetes cluster version
         </Switch>
       </section>
diff --git a/src/renderer/components/+preferences/proxy.tsx b/src/renderer/components/+preferences/proxy.tsx
index 559bea444f..f25c1fbc9b 100644
--- a/src/renderer/components/+preferences/proxy.tsx
+++ b/src/renderer/components/+preferences/proxy.tsx
@@ -28,6 +28,7 @@ import { Switch } from "../switch";
 
 export const LensProxy = observer(() => {
   const [proxy, setProxy] = React.useState(UserStore.getInstance().httpsProxy || "");
+  const store = UserStore.getInstance();
 
   return (
     <section id="proxy">
@@ -50,7 +51,7 @@ export const LensProxy = observer(() => {
 
       <section className="small">
         <SubTitle title="Certificate Trust"/>
-        <Switch checked={UserStore.getInstance().allowUntrustedCAs} onChange={v => UserStore.getInstance().allowUntrustedCAs = v.target.checked}>
+        <Switch checked={store.allowUntrustedCAs} onChange={() => store.allowUntrustedCAs = !store.allowUntrustedCAs}>
           Allow untrusted Certificate Authorities
         </Switch>
         <small className="hint">
diff --git a/src/renderer/components/switch/switch.tsx b/src/renderer/components/switch/switch.tsx
index 4a0c11a1c0..3fe05bdd85 100644
--- a/src/renderer/components/switch/switch.tsx
+++ b/src/renderer/components/switch/switch.tsx
@@ -25,7 +25,6 @@ import React from "react";
 import { cssNames } from "../../utils";
 
 interface Props extends React.HTMLProps<HTMLInputElement> {
-  onChange?: (event: React.ChangeEvent<HTMLInputElement>) => void;
 }
 
 export function Switch({ children, disabled, ...props }: Props) {