From 8bab6bde1492f281bdc8e618dffda2af8dff190d Mon Sep 17 00:00:00 2001 From: Janne Savolainen Date: Tue, 7 Mar 2023 14:56:17 +0200 Subject: [PATCH] Override telemetry by default to optimize and simplify testing Co-authored-by: Mikko Aspiala Signed-off-by: Janne Savolainen --- .../emit-telemetry-from-specific-function-calls.test.ts | 3 +++ .../telemetry-decorator.global-override-for-injectable.ts | 7 +++++++ 2 files changed, 10 insertions(+) create mode 100644 packages/core/src/features/telemetry/renderer/telemetry-decorator.global-override-for-injectable.ts diff --git a/packages/core/src/features/telemetry/emit-telemetry-from-specific-function-calls.test.ts b/packages/core/src/features/telemetry/emit-telemetry-from-specific-function-calls.test.ts index f151a1d550..4185640ebc 100644 --- a/packages/core/src/features/telemetry/emit-telemetry-from-specific-function-calls.test.ts +++ b/packages/core/src/features/telemetry/emit-telemetry-from-specific-function-calls.test.ts @@ -9,12 +9,15 @@ import { getDiForUnitTesting } from "../../renderer/getDiForUnitTesting"; import telemetryWhiteListForFunctionsInjectable from "./renderer/telemetry-white-list-for-functions.injectable"; import emitEventInjectable from "../../common/app-event-bus/emit-event.injectable"; import logErrorInjectable from "../../common/log-error.injectable"; +import telemetryDecoratorInjectable from "./renderer/telemetry-decorator.injectable"; describe("emit-telemetry-from-specific-function-calls", () => { let di: DiContainer; beforeEach(() => { di = getDiForUnitTesting(); + + di.unoverride(telemetryDecoratorInjectable); }); describe("given a telemetry white-list for injectables which instantiate a function", () => { diff --git a/packages/core/src/features/telemetry/renderer/telemetry-decorator.global-override-for-injectable.ts b/packages/core/src/features/telemetry/renderer/telemetry-decorator.global-override-for-injectable.ts new file mode 100644 index 0000000000..7d7138da7a --- /dev/null +++ b/packages/core/src/features/telemetry/renderer/telemetry-decorator.global-override-for-injectable.ts @@ -0,0 +1,7 @@ +import { identity } from "lodash/fp"; +import { getGlobalOverride } from "../../../common/test-utils/get-global-override"; +import telemetryDecoratorInjectable from "./telemetry-decorator.injectable"; + +export default getGlobalOverride(telemetryDecoratorInjectable, () => ({ + decorate: identity, +}));