hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

simplify fix

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2021-10-28 08:18:52 -04:00
parent 3bdb3dfba9
commit 8c8bb94e0f
2 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/renderer/components/+namespaces/namespace-select-filter.tsx
View File

@ -121,7 +121,10 @@ export class NamespaceSelectFilter extends React.Component<SelectProps> {
namespaceStore.toggleSingle(namespace); namespaceStore.toggleSingle(namespace);
} }
} else { } else {
namespaceStore.selectAll(); /**
* WARNING: only ever call this method with `false` as an argument
*/
namespaceStore.toggleAll(false);
} }
}; };

12
src/renderer/components/+namespaces/namespace.store.ts
View File

@ -149,7 +149,7 @@ export class NamespaceStore extends KubeObjectStore<Namespace> {
} }
@computed get hasAllContexts(): boolean { @computed get hasAllContexts(): boolean {
return this.contextNamespaces.length === this.allowedNamespaces.length; return this.selectedNamespaces.length === this.allowedNamespaces.length;
} }
@action @action
@ -167,18 +167,8 @@ export class NamespaceStore extends KubeObjectStore<Namespace> {
this.selectNamespaces(namespace); this.selectNamespaces(namespace);
} }
@action
selectAll() {
this.selectNamespaces([]); // Empty array means "all"
}
/**
* @deprecated This function is broken, `showAll` is opposite of what
*/
@action @action
toggleAll(showAll?: boolean) { toggleAll(showAll?: boolean) {
console.warn("NamespaceStore.toggleAll is deprecated. Use selectAll");
if (typeof showAll === "boolean") { if (typeof showAll === "boolean") {
if (showAll) { if (showAll) {
this.selectNamespaces(this.allowedNamespaces); this.selectNamespaces(this.allowedNamespaces);