hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Refactor showing error notification

Browse Source 
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
This commit is contained in:
Lauri Nevala 2022-01-03 16:48:35 +02:00
parent 2bc7757907
commit 8d52c43a71
1 changed files with 23 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
src/renderer/components/+extensions/attempt-install/create-temp-files-and-validate/create-temp-files-and-validate.tsx
View File

@ -63,7 +63,9 @@ export async function createTempFilesAndValidate({
const manifest = await validatePackage(tempFile); const manifest = await validatePackage(tempFile);
if (!isCompatibleExtension(manifest)){ if (!isCompatibleExtension(manifest)){
throw new Error("Incompatible extension"); displayError(fileName, { message: "Incompatible extension" });
return null;
} }
const id = path.join( const id = path.join(
@ -80,27 +82,31 @@ export async function createTempFilesAndValidate({
id, id,
}; };
} catch (error) { } catch (error) {
const message = getMessageFromError(error); displayError(fileName, error);
logger.info(
`[EXTENSION-INSTALLATION]: installing ${fileName} has failed: ${message}`,
{ error },
);
Notifications.error(
<div className="flex column gaps">
<p>
Installing <em>{fileName}</em> has failed, skipping.
</p>
<p>
Reason: <em>{message}</em>
</p>
</div>,
);
} }
return null; return null;
} }
function displayError(fileName: string, error: any) {
const message = getMessageFromError(error);
logger.info(
`[EXTENSION-INSTALLATION]: installing ${fileName} has failed: ${message}`,
{ error },
);
Notifications.error(
<div className="flex column gaps">
<p>
Installing <em>{fileName}</em> has failed, skipping.
</p>
<p>
Reason: <em>{message}</em>
</p>
</div>,
);
}
function getExtensionPackageTemp(fileName = "") { function getExtensionPackageTemp(fileName = "") {
return path.join(os.tmpdir(), "lens-extensions", fileName); return path.join(os.tmpdir(), "lens-extensions", fileName);