hendrik/lens
1
0 Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Ensure that CatalogEntity.getName() and CatalogEntity.getId() are always used (#4763)

Browse Source
This commit is contained in:
Sebastian Malton authored and GitHub committed 2022-01-27 14:42:19 -05:00
1 parent 1cac3ca74c
commit 8d8491a035
17 files changed
+98 -166
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/common/catalog-entities/kubernetes-cluster.ts
+8 -8
View File
@@ -67,22 +67,22 @@ export class KubernetesCluster extends CatalogEntity<KubernetesClusterMetadata,
async connect(): Promise<void> {
if (app) {
await ClusterStore.getInstance().getById(this.metadata.uid)?.activate();
await ClusterStore.getInstance().getById(this.getId())?.activate();
} else {
await requestClusterActivation(this.metadata.uid, false);
await requestClusterActivation(this.getId(), false);
}
}
async disconnect(): Promise<void> {
if (app) {
ClusterStore.getInstance().getById(this.metadata.uid)?.disconnect();
ClusterStore.getInstance().getById(this.getId())?.disconnect();
} else {
await requestClusterDisconnection(this.metadata.uid, false);
await requestClusterDisconnection(this.getId(), false);
}
}
async onRun(context: CatalogEntityActionContext) {
context.navigate(`/cluster/${this.metadata.uid}`);
context.navigate(`/cluster/${this.getId()}`);
}
onDetailsOpen(): void {
@@ -100,7 +100,7 @@ export class KubernetesCluster extends CatalogEntity<KubernetesClusterMetadata,
icon: "settings",
onClick: () => broadcastMessage(
IpcRendererNavigationEvents.NAVIGATE_IN_APP,
`/entity/${this.metadata.uid}/settings`,
`/entity/${this.getId()}/settings`,
),
});
}
@@ -111,14 +111,14 @@ export class KubernetesCluster extends CatalogEntity<KubernetesClusterMetadata,
context.menuItems.push({
title: "Disconnect",
icon: "link_off",
onClick: () => requestClusterDisconnection(this.metadata.uid),
onClick: () => requestClusterDisconnection(this.getId()),
});
break;
case LensKubernetesClusterStatus.DISCONNECTED:
context.menuItems.push({
title: "Connect",
icon: "link",
onClick: () => context.navigate(`/cluster/${this.metadata.uid}`),
onClick: () => context.navigate(`/cluster/${this.getId()}`),
});
break;
}
src/common/catalog-entities/web-link.ts
+2 -2
View File
@@ -38,9 +38,9 @@ export class WebLink extends CatalogEntity<CatalogEntityMetadata, WebLinkStatus,
context.menuItems.push({
title: "Delete",
icon: "delete",
onClick: async () => WeblinkStore.getInstance().removeById(this.metadata.uid),
onClick: async () => WeblinkStore.getInstance().removeById(this.getId()),
confirm: {
message: `Remove Web Link "${this.metadata.name}" from ${productName}?`,
message: `Remove Web Link "${this.getName()}" from ${productName}?`,
},
});
}