From 8dda513b79b38a05f7d77d3f8ac896c683dc4baa Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Mon, 28 Jun 2021 04:41:01 -0400 Subject: [PATCH] Don't clear searchUrlParam on every change (#3189) Signed-off-by: Sebastian Malton --- .../components/item-object-list/page-filters-list.tsx | 6 +++++- .../components/item-object-list/page-filters.store.ts | 4 ---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/renderer/components/item-object-list/page-filters-list.tsx b/src/renderer/components/item-object-list/page-filters-list.tsx index 49d3245bf9..1bee3be8ba 100644 --- a/src/renderer/components/item-object-list/page-filters-list.tsx +++ b/src/renderer/components/item-object-list/page-filters-list.tsx @@ -27,6 +27,7 @@ import { cssNames } from "../../utils"; import { Filter, pageFilters } from "./page-filters.store"; import { FilterIcon } from "./filter-icon"; import { Icon } from "../icon"; +import { searchUrlParam } from "../input"; interface Props { filters?: Filter[]; @@ -41,7 +42,10 @@ export class PageFiltersList extends React.Component { }; reset = () => pageFilters.reset(); - remove = (filter: Filter) => pageFilters.removeFilter(filter); + remove = (filter: Filter) => { + pageFilters.removeFilter(filter); + searchUrlParam.clear(); + }; renderContent() { const { filters } = this.props; diff --git a/src/renderer/components/item-object-list/page-filters.store.ts b/src/renderer/components/item-object-list/page-filters.store.ts index a6d840dc93..f4fe8ac2f4 100644 --- a/src/renderer/components/item-object-list/page-filters.store.ts +++ b/src/renderer/components/item-object-list/page-filters.store.ts @@ -83,10 +83,6 @@ export class PageFiltersStore { if (filterCopy) this.filters.remove(filterCopy); } - - if (filter.type === FilterType.SEARCH) { - searchUrlParam.clear(); - } } getByType(type: FilterType, value?: any): Filter {