hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Correctly handle HorizontalPodAutoscaler metrics with 0 usage (#5986)

Browse Source
This commit is contained in:
Sebastian Malton 2022-08-04 11:21:01 -07:00 committed by GitHub
parent 04652b4f90
commit 8dea3ad8bc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/common/k8s-api/endpoints/horizontal-pod-autoscaler.api.ts
View File

@ -210,8 +210,6 @@ export class HorizontalPodAutoscalerApi extends KubeApi<HorizontalPodAutoscaler>
} }
} }
function getMetricName(metric: HorizontalPodAutoscalerMetricSpec | HorizontalPodAutoscalerMetricStatus): string | undefined { function getMetricName(metric: HorizontalPodAutoscalerMetricSpec | HorizontalPodAutoscalerMetricStatus): string | undefined {
switch (metric.type) { switch (metric.type) {
case HpaMetricType.Resource: case HpaMetricType.Resource:
@ -232,12 +230,12 @@ function getMetricName(metric: HorizontalPodAutoscalerMetricSpec | HorizontalPod
function getResourceMetricValue(currentMetric: ResourceMetricStatus | undefined, targetMetric: ResourceMetricSource): MetricCurrentTarget { function getResourceMetricValue(currentMetric: ResourceMetricStatus | undefined, targetMetric: ResourceMetricSource): MetricCurrentTarget {
return { return {
current: ( current: (
currentMetric?.currentAverageUtilization typeof currentMetric?.currentAverageUtilization === "number"
? `${currentMetric.currentAverageUtilization}%` ? `${currentMetric.currentAverageUtilization}%`
: currentMetric?.currentAverageValue : currentMetric?.currentAverageValue
), ),
target: ( target: (
targetMetric?.targetAverageUtilization typeof targetMetric?.targetAverageUtilization === "number"
? `${targetMetric.targetAverageUtilization}%` ? `${targetMetric.targetAverageUtilization}%`
: targetMetric?.targetAverageValue : targetMetric?.targetAverageValue
), ),
@ -280,12 +278,12 @@ function getExternalMetricValue(currentMetric: ExternalMetricStatus | undefined,
function getContainerResourceMetricValue(currentMetric: ContainerResourceMetricStatus | undefined, targetMetric: ContainerResourceMetricSource): MetricCurrentTarget { function getContainerResourceMetricValue(currentMetric: ContainerResourceMetricStatus | undefined, targetMetric: ContainerResourceMetricSource): MetricCurrentTarget {
return { return {
current: ( current: (
currentMetric?.currentAverageUtilization typeof currentMetric?.currentAverageUtilization === "number"
? `${currentMetric.currentAverageUtilization}%` ? `${currentMetric.currentAverageUtilization}%`
: currentMetric?.currentAverageValue : currentMetric?.currentAverageValue
), ),
target: ( target: (
targetMetric?.targetAverageUtilization typeof targetMetric?.targetAverageUtilization === "number"
? `${targetMetric.targetAverageUtilization}%` ? `${targetMetric.targetAverageUtilization}%`
: targetMetric?.targetAverageValue : targetMetric?.targetAverageValue
), ),