From 8f84f394fe211978b532979ca74f4a9c3f1f81a9 Mon Sep 17 00:00:00 2001
From: Sebastian Malton <sebastian@malton.name>
Date: Mon, 22 Nov 2021 20:30:47 -0500
Subject: [PATCH] Fix all-or-nothing when initially loading extensions (#4384)

* Fix all-or-nothing when initially loading extensions

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Log error instead of displaying error box

Signed-off-by: Sebastian Malton <sebastian@malton.name>
---
 src/extensions/extension-discovery.ts | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/extensions/extension-discovery.ts b/src/extensions/extension-discovery.ts
index 1463d6180d..dbaeb0142d 100644
--- a/src/extensions/extension-discovery.ts
+++ b/src/extensions/extension-discovery.ts
@@ -393,7 +393,14 @@ export class ExtensionDiscovery extends Singleton {
 
     for (const extension of userExtensions) {
       if ((await fse.pathExists(extension.manifestPath)) === false) {
-        await this.installPackage(extension.absolutePath);
+        try {
+          await this.installPackage(extension.absolutePath);
+        } catch (error) {
+          const message = error.message || error || "unknown error";
+          const { name, version } = extension.manifest;
+
+          logger.error(`${logModule}: failed to install user extension ${name}@${version}`, message);
+        }
       }
     }