hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Remove unnecessary logger as dep

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2023-01-20 10:59:00 -05:00
parent 192b486991
commit 90964239ef
1 changed files with 33 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

92
packages/core/src/renderer/components/+config-pod-disruption-budgets/pod-disruption-budgets-details.tsx
View File

@ -10,70 +10,44 @@ import { observer } from "mobx-react";
import { DrawerItem } from "../drawer"; import { DrawerItem } from "../drawer";
import { Badge } from "../badge"; import { Badge } from "../badge";
import type { KubeObjectDetailsProps } from "../kube-object-details"; import type { KubeObjectDetailsProps } from "../kube-object-details";
import { PodDisruptionBudget } from "../../../common/k8s-api/endpoints"; import type { PodDisruptionBudget } from "../../../common/k8s-api/endpoints";
import type { Logger } from "../../../common/logger";
import { withInjectables } from "@ogre-tools/injectable-react";
import loggerInjectable from "../../../common/logger.injectable";
export interface PodDisruptionBudgetDetailsProps extends KubeObjectDetailsProps<PodDisruptionBudget> { export interface PodDisruptionBudgetDetailsProps extends KubeObjectDetailsProps<PodDisruptionBudget> {
} }
interface Dependencies { export const PodDisruptionBudgetDetails = observer((props: PodDisruptionBudgetDetailsProps) => {
logger: Logger; const { object: pdb } = props;
}
@observer if (!pdb) {
class NonInjectedPodDisruptionBudgetDetails extends React.Component<PodDisruptionBudgetDetailsProps & Dependencies> { return null;
render() {
const { object: pdb } = this.props;
if (!pdb) {
return null;
}
if (!(pdb instanceof PodDisruptionBudget)) {
this.props.logger.error("[PodDisruptionBudgetDetails]: passed object that is not an instanceof PodDisruptionBudget", pdb);
return null;
}
const selectors = pdb.getSelectors();
return (
<div className="PdbDetails">
{selectors.length > 0 && (
<DrawerItem name="Selector" labelsOnly>
{
selectors.map(label => <Badge key={label} label={label}/>)
}
</DrawerItem>
)}
<DrawerItem name="Min Available">
{pdb.getMinAvailable()}
</DrawerItem>
<DrawerItem name="Max Unavailable">
{pdb.getMaxUnavailable()}
</DrawerItem>
<DrawerItem name="Current Healthy">
{pdb.getCurrentHealthy()}
</DrawerItem>
<DrawerItem name="Desired Healthy">
{pdb.getDesiredHealthy()}
</DrawerItem>
</div>
);
} }
}
export const PodDisruptionBudgetDetails = withInjectables<Dependencies, PodDisruptionBudgetDetailsProps>(NonInjectedPodDisruptionBudgetDetails, { const selectors = pdb.getSelectors();
getProps: (di, props) => ({
...props, return (
logger: di.inject(loggerInjectable), <div className="PdbDetails">
}), {selectors.length > 0 && (
<DrawerItem name="Selector" labelsOnly>
{selectors.map(label => <Badge key={label} label={label}/>)}
</DrawerItem>
)}
<DrawerItem name="Min Available">
{pdb.getMinAvailable()}
</DrawerItem>
<DrawerItem name="Max Unavailable">
{pdb.getMaxUnavailable()}
</DrawerItem>
<DrawerItem name="Current Healthy">
{pdb.getCurrentHealthy()}
</DrawerItem>
<DrawerItem name="Desired Healthy">
{pdb.getDesiredHealthy()}
</DrawerItem>
</div>
);
}); });