From 9202db5c20d20d6c288f6c8b0c400c6af52e689c Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Thu, 10 Dec 2020 10:59:13 -0500 Subject: [PATCH] add support for grabbing tagged npm versions Signed-off-by: Sebastian Malton --- src/extensions/extension-loader.ts | 6 ++++-- src/renderer/components/+extensions/extensions.tsx | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/extensions/extension-loader.ts b/src/extensions/extension-loader.ts index d1db45303d..c7cab8983a 100644 --- a/src/extensions/extension-loader.ts +++ b/src/extensions/extension-loader.ts @@ -307,6 +307,8 @@ export class ExtensionLoader { const [, extension ] = instanceEntry; if (extension.manifest.name === name) { + console.log(`found extension ${name}: isEnabled => ${extension.isEnabled}`); + return extension.isEnabled; } } @@ -319,9 +321,9 @@ export class ExtensionLoader { * Get url to the tarball of the extension package. Assumes package is found from npm regisry. * @param packageName e.g. "@mirantis/lens-extension-cc" */ - getNpmPackageTarballUrl(packageName: string): Promise { + getNpmPackageTarballUrl(packageName: string, tag = ""): Promise { return new Promise((resolve, reject) => { - const command = [extensionInstaller.npmPath, "view", packageName, "dist.tarball", "--silent"]; + const command = [extensionInstaller.npmPath, "view", `${packageName}${tag}`, "dist.tarball", "--silent"]; exec(command.join(" "), { encoding: "utf8" diff --git a/src/renderer/components/+extensions/extensions.tsx b/src/renderer/components/+extensions/extensions.tsx index 33ef9ed6e9..54b510d626 100644 --- a/src/renderer/components/+extensions/extensions.tsx +++ b/src/renderer/components/+extensions/extensions.tsx @@ -358,7 +358,7 @@ async function installFromSelectFileDialog() { * @param packageName e.g. "@publisher/extension-name" */ export async function installFromNpm(packageName: string) { - const tarballUrl = await extensionLoader.getNpmPackageTarballUrl(packageName); + const tarballUrl = await extensionLoader.getNpmPackageTarballUrl(packageName, "@hackweek"); Notifications.info(`Installing ${packageName}`);