hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Extract async initialization from sync-injectable

Browse Source 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
Janne Savolainen 2022-04-13 10:47:49 +03:00
parent 6ab70aef22
commit 92f0bec8a2
No known key found for this signature in database
GPG Key ID: 8C6CFB2FFFE8F68A
2 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/extensions/extension-loader/extension-loader.injectable.ts
View File

@ -12,21 +12,15 @@ import extensionInstallationCounterInjectable from "./extension-installation-cou
const extensionLoaderInjectable = getInjectable({ const extensionLoaderInjectable = getInjectable({
id: "extension-loader", id: "extension-loader",
instantiate: (di) => { instantiate: (di) =>
const extensionLoader = new ExtensionLoader({ new ExtensionLoader({
updateExtensionsState: di.inject(updateExtensionsStateInjectable), updateExtensionsState: di.inject(updateExtensionsStateInjectable),
createExtensionInstance: di.inject(createExtensionInstanceInjectable), createExtensionInstance: di.inject(createExtensionInstanceInjectable),
extensionRegistrators: di.injectMany(extensionRegistratorInjectionToken), extensionRegistrators: di.injectMany(extensionRegistratorInjectionToken),
extensionInstallationCounter: di.inject( extensionInstallationCounter: di.inject(
extensionInstallationCounterInjectable, extensionInstallationCounterInjectable,
), ),
}); }),
// TODO: Missing await
extensionLoader.init();
return extensionLoader;
},
}); });
export default extensionLoaderInjectable; export default extensionLoaderInjectable;

3
src/main/start-main-application/after-application-is-ready/implementations/initialize-extensions.injectable.ts
View File

@ -23,7 +23,8 @@ const initializeExtensionsInjectable = getInjectable({
run: async () => { run: async () => {
logger.info("🧩 Initializing extensions"); logger.info("🧩 Initializing extensions");
// call after windowManager to see splash earlier await extensionLoader.init();
try { try {
const extensions = await extensionDiscovery.load(); const extensions = await extensionDiscovery.load();