hendrik/lens
1
0 Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Prevent massed remounting of dock tabs when dock height changes (#6104)

Browse Source 
* Update injectable to make withInjectables have authentic React reconciliation

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Make some dock tabs have primitive props to have them React reconcile properly

Currently tab objects that are stored in a storage change reference on every change of dock height, making them less usable as React prop for causing involuntary remounting.

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
Janne SavolainenandMikko Aspiala authored and GitHub committed 2022-08-25 08:56:09 -04:00
1 parent 1d337a59db
commit 94629954a3
6 files changed
+45 -55
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

package.json
+5 -5
View File
@@ -216,11 +216,11 @@
"@hapi/subtext": "^7.0.4",
"@kubernetes/client-node": "^0.17.0",
"@material-ui/styles": "^4.11.5",
"@ogre-tools/fp": "9.0.1",
"@ogre-tools/injectable": "9.0.2",
"@ogre-tools/injectable-extension-for-auto-registration": "9.0.2",
"@ogre-tools/injectable-extension-for-mobx": "9.0.2",
"@ogre-tools/injectable-react": "9.0.2",
"@ogre-tools/fp": "9.0.3",
"@ogre-tools/injectable": "9.0.3",
"@ogre-tools/injectable-extension-for-auto-registration": "9.0.3",
"@ogre-tools/injectable-extension-for-mobx": "9.0.3",
"@ogre-tools/injectable-react": "9.0.3",
"@sentry/electron": "^3.0.7",
"@sentry/integrations": "^6.19.3",
"@side/jest-runtime": "^1.0.1",