Replace duplicated overrides with global

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

src/behaviours/preferences/navigation-to-extension-specific-preferences.test.tsx

@@ -46,6 +46,7 @@ describe("preferences - navigation to extension specific preferences", () => {
     describe("when extension with specific preferences is enabled", () => {
       beforeEach(() => {
         const getRendererExtensionFake = getRendererExtensionFakeFor(applicationBuilder);
+
         const testExtension = getRendererExtensionFake(extensionStubWithExtensionSpecificPreferenceItems);
 
         applicationBuilder.addExtensions(testExtension);
@@ -95,6 +96,7 @@ describe("preferences - navigation to extension specific preferences", () => {
 const extensionStubWithExtensionSpecificPreferenceItems: FakeExtensionData = {
   id: "some-extension-id",
   name: "some-extension-name",
+
   appPreferences: [
     {
       title: "Some preference item",

src/behaviours/preferences/navigation-to-telemetry-preferences.test.tsx

@@ -48,6 +48,7 @@ describe("preferences - navigation to telemetry preferences", () => {
     describe("when extension with telemetry preference items gets enabled", () => {
       beforeEach(() => {
         const getRendererExtensionFake = getRendererExtensionFakeFor(applicationBuilder);
+
         const testExtensionWithTelemetryPreferenceItems = getRendererExtensionFake(extensionStubWithTelemetryPreferenceItems);
 
         applicationBuilder.addExtensions(
@@ -92,6 +93,7 @@ describe("preferences - navigation to telemetry preferences", () => {
 
     it("given extensions but no telemetry preference items, does not show link for telemetry preferences", () => {
       const getRendererExtensionFake = getRendererExtensionFakeFor(applicationBuilder);
+
       const testExtensionWithTelemetryPreferenceItems = getRendererExtensionFake({
         id: "some-test-extension-id",
         name: "some-test-extension-name",

src/behaviours/preferences/navigation-to-terminal-preferences.test.ts

@@ -5,17 +5,12 @@
 import type { RenderResult } from "@testing-library/react";
 import type { ApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
 import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
-import defaultShellInjectable from "../../renderer/components/+preferences/default-shell.injectable";
 
 describe("preferences - navigation to terminal preferences", () => {
   let applicationBuilder: ApplicationBuilder;
 
   beforeEach(() => {
     applicationBuilder = getApplicationBuilder();
-
-    applicationBuilder.beforeApplicationStart(({ rendererDi }) => {
-      rendererDi.override(defaultShellInjectable, () => "some-default-shell");
-    });
   });
 
   describe("given in preferences, when rendered", () => {