From 9527ee83555a44a7a4d62ee09168f56addc4187a Mon Sep 17 00:00:00 2001 From: Alex Andreev Date: Thu, 5 May 2022 11:48:03 +0300 Subject: [PATCH] Little clean up Signed-off-by: Alex Andreev --- ...xtension-specific-preferences.test.tsx.snap | 16 ++++++++-------- ...-to-extension-specific-preferences.test.tsx | 18 +++++++++--------- .../+preferences/__tests__/extensions.test.tsx | 8 ++++---- ...-preferences-navigation-item.injectable.ts} | 0 4 files changed, 21 insertions(+), 21 deletions(-) rename src/renderer/components/+preferences/preferences-navigation/{extension-general-preferences-navigation-item.injectable.ts => extension-tab-preferences-navigation-item.injectable.ts} (100%) diff --git a/src/behaviours/preferences/__snapshots__/navigation-to-extension-specific-preferences.test.tsx.snap b/src/behaviours/preferences/__snapshots__/navigation-to-extension-specific-preferences.test.tsx.snap index 0692cbeabb..f6f72d2efc 100644 --- a/src/behaviours/preferences/__snapshots__/navigation-to-extension-specific-preferences.test.tsx.snap +++ b/src/behaviours/preferences/__snapshots__/navigation-to-extension-specific-preferences.test.tsx.snap @@ -3,14 +3,14 @@ exports[`preferences - navigation to extension specific preferences given in preferences, when rendered given extension with registered tab shows extension tab in general area 1`] = ` `; @@ -97,14 +97,14 @@ exports[`preferences - navigation to extension specific preferences given in pre @@ -126,8 +126,8 @@ exports[`preferences - navigation to extension specific preferences given in pre
diff --git a/src/behaviours/preferences/navigation-to-extension-specific-preferences.test.tsx b/src/behaviours/preferences/navigation-to-extension-specific-preferences.test.tsx index d719f22e42..710ea98260 100644 --- a/src/behaviours/preferences/navigation-to-extension-specific-preferences.test.tsx +++ b/src/behaviours/preferences/navigation-to-extension-specific-preferences.test.tsx @@ -174,7 +174,7 @@ describe("preferences - navigation to extension specific preferences", () => { }); it("shows extension tab in general area", () => { - const actual = rendered.getByTestId("tab-link-for-extension-specific-tab-navigation-item-license-extension-tab"); + const actual = rendered.getByTestId("tab-link-for-extension-specific-tab-navigation-item-metrics-extension-tab"); expect(actual).toMatchSnapshot(); }); @@ -187,13 +187,13 @@ describe("preferences - navigation to extension specific preferences", () => { describe("when navigating to specific extension tab", () => { beforeEach(() => { - applicationBuilder.preferences.navigation.click("extension-specific-tab-navigation-item-license-extension-tab"); + applicationBuilder.preferences.navigation.click("extension-specific-tab-navigation-item-metrics-extension-tab"); }); it("renders", () => { expect(rendered.container).toMatchSnapshot(); }); it("shows related preferences for this tab", () => { - const actual = rendered.getByTestId("license-preference-item-hint"); + const actual = rendered.getByTestId("metrics-preference-item-hint"); expect(actual).toBeInTheDocument(); }); @@ -277,12 +277,12 @@ const extensionStubWithWithRegisteredTab: Partial = { appPreferences: [ { title: "License item", - id: "license-preference-item-id", - showInPreferencesTab: "license-extension-tab", + id: "metrics-preference-item-id", + showInPreferencesTab: "metrics-extension-tab", components: { - Hint: () =>
, - Input: () =>
, + Hint: () =>
, + Input: () =>
, }, }, { @@ -308,8 +308,8 @@ const extensionStubWithWithRegisteredTab: Partial = { ], appPreferenceTabs: [{ - title: "License tab", - id: "license-extension-tab", + title: "Metrics tab", + id: "metrics-extension-tab", orderNumber: 100, }], }; diff --git a/src/renderer/components/+preferences/__tests__/extensions.test.tsx b/src/renderer/components/+preferences/__tests__/extensions.test.tsx index 99200cf546..cc1cd507c9 100644 --- a/src/renderer/components/+preferences/__tests__/extensions.test.tsx +++ b/src/renderer/components/+preferences/__tests__/extensions.test.tsx @@ -53,7 +53,7 @@ describe("", () => { describe("when tabId param is passed and extension has same showInPreferencesTab param", () => { beforeEach(() => { - di.override(currentPathParametersInjectable, () => computed(() => ({ extensionId: "some-test-extension-id", tabId: "license-extension-tab" }))); + di.override(currentPathParametersInjectable, () => computed(() => ({ extensionId: "some-test-extension-id", tabId: "metircs-extension-tab" }))); }); it("does render related preferences for specific tab", () => { @@ -107,7 +107,7 @@ const extensionWithSpecificPreferenceItems: Partial = { { title: "preference for specific tab", id: "preference-for-tab-item-id", - showInPreferencesTab: "license-extension-tab", + showInPreferencesTab: "metircs-extension-tab", components: { Hint: () =>
, @@ -117,8 +117,8 @@ const extensionWithSpecificPreferenceItems: Partial = { ], appPreferenceTabs: [{ - title: "License tab", - id: "license-extension-tab", + title: "Metrics tab", + id: "metircs-extension-tab", orderNumber: 100, }], }; diff --git a/src/renderer/components/+preferences/preferences-navigation/extension-general-preferences-navigation-item.injectable.ts b/src/renderer/components/+preferences/preferences-navigation/extension-tab-preferences-navigation-item.injectable.ts similarity index 100% rename from src/renderer/components/+preferences/preferences-navigation/extension-general-preferences-navigation-item.injectable.ts rename to src/renderer/components/+preferences/preferences-navigation/extension-tab-preferences-navigation-item.injectable.ts