Fixing Singleton typing to correctly return child class (#1914)

- Add distinction between `getInstance` and `getInstanceOrCreate` since
  it is not always possible to create an instance (since you might not
  know the correct arguments)

- Remove all the `export const *Store = *Store.getInstance<*Store>();`
  calls as it defeats the purpose of `Singleton`. Plus with the typing
  changes the appropriate `*Store.getInstance()` is "short enough".

- Special case the two extension export facades to not need to use
  `getInstanceOrCreate`. Plus since they are just facades it is always
  possible to create them.

- Move some other types to be also `Singleton`'s: ExtensionLoader,
  ExtensionDiscovery, ThemeStore, LocalizationStore, ...

- Fixed dev-run always using the same port with electron inspect

- Update Store documentation with new recommendations about creating
  instances of singletons

- Fix all unit tests to create their dependent singletons

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/renderer/protocol-handler/app-handlers.ts

@@ -5,13 +5,13 @@ import { preferencesURL } from "../components/+preferences";
 import { clusterViewURL } from "../components/cluster-manager/cluster-view.route";
 import { LensProtocolRouterRenderer } from "./router";
 import { navigate } from "../navigation/helpers";
-import { clusterStore } from "../../common/cluster-store";
 import { entitySettingsURL } from "../components/+entity-settings";
 import { catalogEntityRegistry } from "../api/catalog-entity-registry";
+import { ClusterStore } from "../../common/cluster-store";
 
 export function bindProtocolAddRouteHandlers() {
   LensProtocolRouterRenderer
-    .getInstance<LensProtocolRouterRenderer>()
+    .getInstance()
     .addInternalHandler("/preferences", ({ search: { highlight }}) => {
       navigate(preferencesURL({ fragment: highlight }));
     })
@@ -36,9 +36,9 @@ export function bindProtocolAddRouteHandlers() {
     .addInternalHandler("/extensions", () => {
       navigate(extensionsURL());
     })
-    // Handlers below are deprecated and only kept for backward compat purposes
+    // Handlers below are deprecated and only kept for backward compact purposes
     .addInternalHandler("/cluster/:clusterId", ({ pathname: { clusterId } }) => {
-      const cluster = clusterStore.getById(clusterId);
+      const cluster = ClusterStore.getInstance().getById(clusterId);
 
       if (cluster) {
         navigate(clusterViewURL({ params: { clusterId } }));
@@ -47,7 +47,7 @@ export function bindProtocolAddRouteHandlers() {
       }
     })
     .addInternalHandler("/cluster/:clusterId/settings", ({ pathname: { clusterId } }) => {
-      const cluster = clusterStore.getById(clusterId);
+      const cluster = ClusterStore.getInstance().getById(clusterId);
 
       if (cluster) {
         navigate(entitySettingsURL({ params: { entityId: clusterId } }));