Clear up some NamespaceStore methods

- Deprecate toggleAll in favour of selectAll because the other was
  dangerous, mostly broken, and didn't toggle

- Fix hasAllContexts to be true in the [] case

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/renderer/components/+namespaces/namespace-select-filter.tsx

@@ -121,10 +121,7 @@ export class NamespaceSelectFilter extends React.Component<SelectProps> {
         namespaceStore.toggleSingle(namespace);
       }
     } else {
-      /**
+      namespaceStore.selectAll();
-       * WARNING: only ever call this method with `false` as an argument
-       */
-      namespaceStore.toggleAll(false);
     }
   };
 

src/renderer/components/+namespaces/namespace.store.ts

@@ -148,8 +148,11 @@ export class NamespaceStore extends KubeObjectStore<Namespace> {
       .every(namespace => this.selectedNamespaces.includes(namespace));
   }
 
+  /**
+   * Is `true` if all available namespaces are selected, otherwise `false`
+   */
   @computed get hasAllContexts(): boolean {
-    return this.selectedNamespaces.length === this.allowedNamespaces.length;
+    return this.contextNamespaces.length === this.allowedNamespaces.length;
   }
 
   @action
@@ -167,17 +170,21 @@ export class NamespaceStore extends KubeObjectStore<Namespace> {
     this.selectNamespaces(namespace);
   }
 
-  @action
+  /**
-  toggleAll(showAll?: boolean) {
+   * Selects all available namespaces.
-    if (typeof showAll === "boolean") {
+   *
-      if (showAll) {
+   * Note: If new namespaces appear in the future those will be selected too
-        this.selectNamespaces(this.allowedNamespaces);
+   */
-      } else {
+  selectAll() {
-        this.selectNamespaces([]); // empty context considered as "All namespaces"
+    this.selectNamespaces([]);
-      }
+  }
-    } else {
+
-      this.toggleAll(!this.hasAllContexts);
+  /**
-    }
+   * @deprecated Use `NamespaceStore.selectAll` instead
+   */
+  toggleAll(selectAll?: boolean) {
+    void selectAll;
+    this.selectAll();
   }
 
   @action