Make EntitySettingRegistry fully injectable (#6604)

* Make EntitySettingRegistry fully injectable

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Add behavioural tests

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix lint

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Revert tsconfig change

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix type errors

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Update snapshot

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Improve naming

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/extensions/extension-loader/extension-loader.ts

@@ -261,7 +261,6 @@ export class ExtensionLoader {
     return this.autoInitExtensions(async (ext) => {
       const extension = ext as LensRendererExtension;
       const removeItems = [
-        registries.EntitySettingRegistry.getInstance().add(extension.entitySettings),
         registries.CatalogEntityDetailRegistry.getInstance().add(extension.catalogEntityDetailItems),
       ];
 

src/extensions/lens-renderer-extension.ts

@@ -29,6 +29,7 @@ import type { KubeObjectHandlerRegistration } from "../renderer/kube-object/hand
 import type { AppPreferenceTabRegistration } from "../features/preferences/renderer/compliance-for-legacy-extension-api/app-preference-tab-registration";
 import type { KubeObjectDetailRegistration } from "../renderer/components/kube-object-details/kube-object-detail-registration";
 import type { ClusterFrameChildComponent } from "../renderer/frames/cluster-frame/cluster-frame-child-component-injection-token";
+import type { EntitySettingRegistration } from "../renderer/components/+entity-settings/extension-registrator.injectable";
 
 export class LensRendererExtension extends LensExtension<LensRendererExtensionDependencies> {
   globalPages: registries.PageRegistration[] = [];
@@ -38,7 +39,7 @@ export class LensRendererExtension extends LensExtension<LensRendererExtensionDe
   kubeObjectStatusTexts: KubeObjectStatusRegistration[] = [];
   appPreferences: AppPreferenceRegistration[] = [];
   appPreferenceTabs: AppPreferenceTabRegistration[] = [];
-  entitySettings: registries.EntitySettingRegistration[] = [];
+  entitySettings: EntitySettingRegistration[] = [];
   statusBarItems: StatusBarRegistration[] = [];
   kubeObjectDetailItems: KubeObjectDetailRegistration[] = [];
   kubeObjectMenuItems: KubeObjectMenuRegistration[] = [];

src/extensions/registries/entity-setting-registry.ts

@@ -1,54 +0,0 @@
-/**
- * Copyright (c) OpenLens Authors. All rights reserved.
- * Licensed under MIT License. See LICENSE in root directory for more information.
- */
-
-import type React from "react";
-import type { CatalogEntity } from "../../common/catalog";
-import { BaseRegistry } from "./base-registry";
-
-export interface EntitySettingViewProps {
-  entity: CatalogEntity;
-}
-
-export interface EntitySettingComponents {
-  View: React.ComponentType<EntitySettingViewProps>;
-}
-
-export interface EntitySettingRegistration {
-  apiVersions: string[];
-  kind: string;
-  title: string;
-  components: EntitySettingComponents;
-  source?: string;
-  id?: string;
-  priority?: number;
-  group?: string;
-}
-
-export interface RegisteredEntitySetting extends EntitySettingRegistration {
-  id: string;
-}
-
-export class EntitySettingRegistry extends BaseRegistry<EntitySettingRegistration, RegisteredEntitySetting> {
-  getRegisteredItem(item: EntitySettingRegistration): RegisteredEntitySetting {
-    return {
-      id: item.id || item.title.toLowerCase(),
-      ...item,
-    };
-  }
-
-  getItemsForKind(kind: string, apiVersion: string, source?: string) {
-    let items = this.getItems().filter((item) => {
-      return item.kind === kind && item.apiVersions.includes(apiVersion);
-    });
-
-    if (source) {
-      items = items.filter((item) => {
-        return !item.source || item.source === source;
-      });
-    }
-
-    return items.sort((a, b) => (b.priority ?? 50) - (a.priority ?? 50));
-  }
-}

src/extensions/registries/index.ts

@@ -7,6 +7,5 @@
 
 export * from "./page-registry";
 export * from "./page-menu-registry";
-export * from "./entity-setting-registry";
 export * from "./catalog-entity-detail-registry";
 export * from "./protocol-handler";