mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
feat: Introduce reusable script to build using webpack
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
parent
9a4b02becb
commit
98fe1a38bf
3
package-lock.json
generated
3
package-lock.json
generated
@ -36595,6 +36595,9 @@
|
||||
"webpack": "^5.81.0",
|
||||
"webpack-cli": "^4.10.0"
|
||||
},
|
||||
"bin": {
|
||||
"lens-webpack-build": "bin/webpack-build"
|
||||
},
|
||||
"devDependencies": {
|
||||
"@async-fn/jest": "^1.6.4",
|
||||
"@k8slens/test-utils": "^1.0.0-alpha.1",
|
||||
|
||||
4
packages/infrastructure/webpack/bin/webpack-build
Executable file
4
packages/infrastructure/webpack/bin/webpack-build
Executable file
@ -0,0 +1,4 @@
|
||||
#!/usr/bin/env node
|
||||
const { doWebpackBuild } = require("../dist/index");
|
||||
|
||||
doWebpackBuild();
|
||||
10
packages/infrastructure/webpack/do-webpack-build.ts
Normal file
10
packages/infrastructure/webpack/do-webpack-build.ts
Normal file
@ -0,0 +1,10 @@
|
||||
import { getDi } from "./src/scripts/get-di";
|
||||
import { doWebpackBuildInjectable } from "./src/scripts/do-webpack-build";
|
||||
|
||||
export const doWebpackBuild = () => {
|
||||
const di = getDi();
|
||||
|
||||
const doWebpackBuild = di.inject(doWebpackBuildInjectable);
|
||||
|
||||
doWebpackBuild();
|
||||
};
|
||||
@ -1,3 +1,4 @@
|
||||
export { configForNode } from "./src/node-config";
|
||||
export { configForReact } from "./src/react-config";
|
||||
export { getMultiExportConfig } from "./src/get-multi-export-config";
|
||||
export { doWebpackBuild } from "./do-webpack-build";
|
||||
|
||||
@ -48,5 +48,8 @@
|
||||
"@k8slens/typescript": "^6.5.0-alpha.2",
|
||||
"ts-node": "^10.9.1",
|
||||
"webpack-node-externals": "^3.0.0"
|
||||
},
|
||||
"bin": {
|
||||
"lens-webpack-build": "bin/webpack-build"
|
||||
}
|
||||
}
|
||||
|
||||
@ -0,0 +1,89 @@
|
||||
import { getDi } from "./get-di";
|
||||
import { Exec, execInjectable } from "./exec.injectable";
|
||||
import asyncFn, { AsyncFnMock } from "@async-fn/jest";
|
||||
import { DoWebpackBuild, doWebpackBuildInjectable } from "./do-webpack-build";
|
||||
import { getPromiseStatus } from "@k8slens/test-utils";
|
||||
import { LogSuccess, logSuccessInjectable } from "./log-success.injectable";
|
||||
|
||||
describe("do-webpack-build", () => {
|
||||
let execMock: AsyncFnMock<Exec>;
|
||||
let doWebpackBuild: DoWebpackBuild;
|
||||
let logSuccessMock: AsyncFnMock<LogSuccess>;
|
||||
|
||||
beforeEach(() => {
|
||||
const di = getDi();
|
||||
|
||||
execMock = asyncFn();
|
||||
di.override(execInjectable, () => execMock);
|
||||
logSuccessMock = asyncFn();
|
||||
di.override(logSuccessInjectable, () => logSuccessMock);
|
||||
|
||||
doWebpackBuild = di.inject(doWebpackBuildInjectable);
|
||||
});
|
||||
|
||||
describe("when called", () => {
|
||||
let actualPromise: Promise<void>;
|
||||
|
||||
beforeEach(() => {
|
||||
actualPromise = doWebpackBuild();
|
||||
});
|
||||
|
||||
it("calls webpack", () => {
|
||||
expect(execMock).toHaveBeenCalledWith("webpack");
|
||||
});
|
||||
|
||||
it("does not resolve yet", async () => {
|
||||
const promiseStatus = await getPromiseStatus(actualPromise);
|
||||
|
||||
expect(promiseStatus.fulfilled).toBe(false);
|
||||
});
|
||||
|
||||
describe("when webpack resolves with stdout", () => {
|
||||
beforeEach(async () => {
|
||||
await execMock.resolve({ stdout: "some-stdout", stderr: "" });
|
||||
});
|
||||
|
||||
it("logs the stdout", () => {
|
||||
expect(logSuccessMock).toHaveBeenCalledWith("some-stdout");
|
||||
});
|
||||
|
||||
it("script finishes", async () => {
|
||||
const promiseStatus = await getPromiseStatus(actualPromise);
|
||||
|
||||
expect(promiseStatus.fulfilled).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
describe("when webpack resolves with stderr", () => {
|
||||
beforeEach(() => {
|
||||
execMock.resolve({ stdout: "", stderr: "some-stderr" });
|
||||
});
|
||||
|
||||
it("does not log success", () => {
|
||||
actualPromise.catch(() => {});
|
||||
|
||||
expect(logSuccessMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("throws", () => {
|
||||
return expect(actualPromise).rejects.toThrow("some-stderr");
|
||||
});
|
||||
});
|
||||
|
||||
describe("when webpack rejects", () => {
|
||||
beforeEach(() => {
|
||||
execMock.reject(new Error("some-error"));
|
||||
});
|
||||
|
||||
it("does not log success", () => {
|
||||
actualPromise.catch(() => {});
|
||||
|
||||
expect(logSuccessMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("throws", () => {
|
||||
return expect(actualPromise).rejects.toThrow("some-error");
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
@ -0,0 +1,24 @@
|
||||
import { getInjectable } from "@ogre-tools/injectable";
|
||||
import { execInjectable } from "./exec.injectable";
|
||||
import { logSuccessInjectable } from "./log-success.injectable";
|
||||
|
||||
export type DoWebpackBuild = () => Promise<void>;
|
||||
|
||||
export const doWebpackBuildInjectable = getInjectable({
|
||||
id: "do-webpack-build",
|
||||
|
||||
instantiate: (di) => {
|
||||
const exec = di.inject(execInjectable);
|
||||
const logSuccess = di.inject(logSuccessInjectable);
|
||||
|
||||
return async () => {
|
||||
const { stdout, stderr } = await exec("webpack");
|
||||
|
||||
if (stderr) {
|
||||
throw new Error(stderr);
|
||||
}
|
||||
|
||||
logSuccess(stdout);
|
||||
};
|
||||
},
|
||||
});
|
||||
@ -0,0 +1,12 @@
|
||||
import { getInjectable } from "@ogre-tools/injectable";
|
||||
import { exec } from "child_process";
|
||||
import { promisify } from "util";
|
||||
|
||||
const promisifiedExec = promisify(exec);
|
||||
|
||||
export type Exec = typeof promisifiedExec;
|
||||
|
||||
export const execInjectable = getInjectable({
|
||||
id: "exec",
|
||||
instantiate: () => promisifiedExec,
|
||||
});
|
||||
12
packages/infrastructure/webpack/src/scripts/get-di.ts
Normal file
12
packages/infrastructure/webpack/src/scripts/get-di.ts
Normal file
@ -0,0 +1,12 @@
|
||||
import { createContainer } from "@ogre-tools/injectable";
|
||||
import { execInjectable } from "./exec.injectable";
|
||||
import { doWebpackBuildInjectable } from "./do-webpack-build";
|
||||
import { logSuccessInjectable } from "./log-success.injectable";
|
||||
|
||||
export const getDi = () => {
|
||||
const di = createContainer("do-webpack-build");
|
||||
|
||||
di.register(execInjectable, doWebpackBuildInjectable, logSuccessInjectable);
|
||||
|
||||
return di;
|
||||
};
|
||||
@ -0,0 +1,8 @@
|
||||
import { getInjectable } from "@ogre-tools/injectable";
|
||||
|
||||
export type LogSuccess = typeof console.log;
|
||||
|
||||
export const logSuccessInjectable = getInjectable({
|
||||
id: "log-success",
|
||||
instantiate: (di): LogSuccess => console.log,
|
||||
});
|
||||
Loading…
Reference in New Issue
Block a user