From 99c3b3a07ad5870205cb90f7e514aaf6b4f1ef9b Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Wed, 15 Mar 2023 11:58:32 -0400 Subject: [PATCH] Add explanatory comment for inline require Signed-off-by: Sebastian Malton --- .../src/common/example-bundled-extension.injectable.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/open-lens/src/common/example-bundled-extension.injectable.ts b/packages/open-lens/src/common/example-bundled-extension.injectable.ts index 92cdf56cd9..8b65c985fb 100644 --- a/packages/open-lens/src/common/example-bundled-extension.injectable.ts +++ b/packages/open-lens/src/common/example-bundled-extension.injectable.ts @@ -6,6 +6,12 @@ const exampleBundledExtensionInjectable = getInjectable({ id: "example-bundled-extension", instantiate: (di) => ({ manifest: exampleBundledExtensionManifest, + /** + * Inline `require` is needed as to delay the loading and execution of the JS file until it is needed. + * + * Futhermore there might be code that runs "during load" and shouldn't be executed until everything is + * setup for the extensions (ie globals). + */ main: () => require("@k8slens/legacy-extension-example/main").default, renderer: () => require("@k8slens/legacy-extension-example/renderer").default, }),