From 9a4e9f8ec71973e6e8968944b965855ac98a42b7 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Mon, 13 Jun 2022 09:09:42 -0400 Subject: [PATCH] Resolve PR comments Signed-off-by: Sebastian Malton --- src/main/protocol-handler/__test__/router.test.ts | 4 ++-- .../components/layout/top-bar/start-state-sync.injectable.ts | 1 + src/renderer/getDiForUnitTesting.tsx | 4 ++++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/main/protocol-handler/__test__/router.test.ts b/src/main/protocol-handler/__test__/router.test.ts index 545f8cc7eb..868aaee7dc 100644 --- a/src/main/protocol-handler/__test__/router.test.ts +++ b/src/main/protocol-handler/__test__/router.test.ts @@ -54,12 +54,12 @@ describe("protocol router tests", () => { lpr.rendererLoaded = true; }); - it("should throw on non-lens URLS", async () => { + it("should broadcast invalid protocol on non-lens URLs", async () => { await lpr.route("https://google.ca"); expect(broadcastMessage).toBeCalledWith(ProtocolHandlerInvalid, "invalid protocol", "https://google.ca"); }); - it("should throw when host not internal or extension", async () => { + it("should broadcast invalid host on non internal or non extension URLs", async () => { await lpr.route("lens://foobar"); expect(broadcastMessage).toBeCalledWith(ProtocolHandlerInvalid, "invalid host", "lens://foobar"); }); diff --git a/src/renderer/components/layout/top-bar/start-state-sync.injectable.ts b/src/renderer/components/layout/top-bar/start-state-sync.injectable.ts index 7ca881d527..6f9370c679 100644 --- a/src/renderer/components/layout/top-bar/start-state-sync.injectable.ts +++ b/src/renderer/components/layout/top-bar/start-state-sync.injectable.ts @@ -28,6 +28,7 @@ const startTopbarStateSyncInjectable = getInjectable({ }; }, injectionToken: beforeFrameStartsInjectionToken, + causesSideEffects: true, }); export default startTopbarStateSyncInjectable; diff --git a/src/renderer/getDiForUnitTesting.tsx b/src/renderer/getDiForUnitTesting.tsx index c58511d2bc..3c25ee96aa 100644 --- a/src/renderer/getDiForUnitTesting.tsx +++ b/src/renderer/getDiForUnitTesting.tsx @@ -50,6 +50,7 @@ import getRandomIdInjectable from "../common/utils/get-random-id.injectable"; import getFilePathsInjectable from "./components/+preferences/kubernetes/helm-charts/adding-of-custom-helm-repository/helm-file-input/get-file-paths.injectable"; import callForPublicHelmRepositoriesInjectable from "./components/+preferences/kubernetes/helm-charts/adding-of-public-helm-repository/public-helm-repositories/call-for-public-helm-repositories.injectable"; import platformInjectable from "../common/vars/platform.injectable"; +import startTopbarStateSyncInjectable from "./components/layout/top-bar/start-state-sync.injectable"; export const getDiForUnitTesting = (opts: { doGeneralOverrides?: boolean } = {}) => { const { @@ -74,6 +75,9 @@ export const getDiForUnitTesting = (opts: { doGeneralOverrides?: boolean } = {}) if (doGeneralOverrides) { di.override(getRandomIdInjectable, () => () => "some-irrelevant-random-id"); di.override(platformInjectable, () => "darwin"); + di.override(startTopbarStateSyncInjectable, () => ({ + run: () => {}, + })); di.override(terminalSpawningPoolInjectable, () => document.createElement("div")); di.override(hostedClusterIdInjectable, () => undefined);