Migrate to actual typing for di.permitSideEffects

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
This commit is contained in:
Iku-turso authored and Janne Savolainen committed 2022-03-31 15:13:30 +03:00
1 parent 906f23214e
commit 9a5a210ed3
15 files changed
+18 -62

No files matched your search

+3 -3
View File
@@ -202,9 +202,9 @@
"@hapi/call": "^8.0.1",
"@hapi/subtext": "^7.0.3",
"@kubernetes/client-node": "^0.16.3",
"@ogre-tools/injectable": "5.1.3",
"@ogre-tools/injectable-react": "5.1.3",
"@ogre-tools/fp": "5.1.3",
"@ogre-tools/injectable": "5.2.0",
"@ogre-tools/injectable-react": "5.2.0",
"@ogre-tools/fp": "5.2.0",
"@sentry/electron": "^2.5.4",
"@sentry/integrations": "^6.19.2",
"@types/circular-dependency-plugin": "5.0.5",
-4
View File
@@ -85,11 +85,7 @@ describe("BaseStore", () => {
const mainDi = getDiForUnitTesting({ doGeneralOverrides: true });
mainDi.override(directoryForUserDataInjectable, () => "some-user-data-directory");
// @ts-ignore
mainDi.permitSideEffects(getConfigurationFileModelInjectable);
// @ts-ignore
mainDi.permitSideEffects(appVersionInjectable);
await mainDi.runSetups();
@@ -92,10 +92,7 @@ describe("cluster-store", () => {
mainDi.override(clusterStoreInjectable, (di) => ClusterStore.createInstance({ createCluster: di.inject(createClusterInjectionToken) }));
mainDi.override(directoryForUserDataInjectable, () => "some-directory-for-user-data");
// @ts-ignore
mainDi.permitSideEffects(getConfigurationFileModelInjectable);
// @ts-ignore
mainDi.permitSideEffects(appVersionInjectable);
await mainDi.runSetups();
@@ -134,13 +134,8 @@ describe("HotbarStore", () => {
beforeEach(async () => {
di = getDiForUnitTesting({ doGeneralOverrides: true });
// @ts-ignore
di.permitSideEffects(hotbarStoreInjectable);
// @ts-ignore
di.permitSideEffects(getConfigurationFileModelInjectable);
// @ts-ignore
di.permitSideEffects(appVersionInjectable);
});
-3
View File
@@ -53,10 +53,7 @@ describe("user store tests", () => {
di.override(directoryForUserDataInjectable, () => "some-directory-for-user-data");
di.override(userStoreInjectable, () => UserStore.createInstance());
// @ts-ignore
di.permitSideEffects(getConfigurationFileModelInjectable);
// @ts-ignore
di.permitSideEffects(appVersionInjectable);
await di.runSetups();
@@ -98,10 +98,7 @@ describe("kube auth proxy tests", () => {
di.override(spawnInjectable, () => mockSpawn);
// @ts-ignore
di.permitSideEffects(getConfigurationFileModelInjectable);
// @ts-ignore
di.permitSideEffects(appVersionInjectable);
mockFs(mockMinikubeConfig);
@@ -56,10 +56,7 @@ describe("kubeconfig-sync.source tests", () => {
ClusterStore.createInstance({ createCluster: () => null }),
);
// @ts-ignore
di.permitSideEffects(getConfigurationFileModelInjectable);
// @ts-ignore
di.permitSideEffects(appVersionInjectable);
di.inject(clusterStoreInjectable);
@@ -48,10 +48,7 @@ describe("protocol router tests", () => {
di.override(extensionsStoreInjectable, () => ExtensionsStore.createInstance());
// @ts-ignore
di.permitSideEffects(getConfigurationFileModelInjectable);
// @ts-ignore
di.permitSideEffects(appVersionInjectable);
await di.runSetups();
@@ -99,10 +99,7 @@ describe("<Catalog />", () => {
di.override(directoryForUserDataInjectable, () => "some-directory-for-user-data");
// @ts-ignore
di.permitSideEffects(getConfigurationFileModelInjectable);
// @ts-ignore
di.permitSideEffects(appVersionInjectable);
await di.runSetups();
@@ -57,10 +57,7 @@ describe("Extensions", () => {
di.override(directoryForUserDataInjectable, () => "some-directory-for-user-data");
di.override(directoryForDownloadsInjectable, () => "some-directory-for-downloads");
// @ts-ignore
di.permitSideEffects(getConfigurationFileModelInjectable);
// @ts-ignore
di.permitSideEffects(appVersionInjectable);
mockFs({
@@ -84,10 +84,7 @@ describe("<DockTabs />", () => {
() => "some-test-suite-specific-directory-for-user-data",
);
// @ts-ignore
di.permitSideEffects(getConfigurationFileModelInjectable);
// @ts-ignore
di.permitSideEffects(appVersionInjectable);
await di.runSetups();
@@ -135,10 +135,7 @@ describe("<LogResourceSelector />", () => {
di.override(directoryForUserDataInjectable, () => "some-directory-for-user-data");
di.override(callForLogsInjectable, () => () => Promise.resolve("some-logs"));
// @ts-ignore
di.permitSideEffects(getConfigurationFileModelInjectable);
// @ts-ignore
di.permitSideEffects(appVersionInjectable);
render = renderFor(di);
@@ -45,13 +45,8 @@ describe("<HotbarRemoveCommand />", () => {
di.override(directoryForUserDataInjectable, () => "some-directory-for-user-data");
// @ts-ignore
di.permitSideEffects(hotbarStoreInjectable);
// @ts-ignore
di.permitSideEffects(getConfigurationFileModelInjectable);
// @ts-ignore
di.permitSideEffects(appVersionInjectable);
render = renderFor(di);
@@ -42,10 +42,7 @@ describe("<Select />", () => {
di.override(directoryForUserDataInjectable, () => "some-directory-for-user-data");
di.override(rendererExtensionsInjectable, () => computed(() => [] as LensRendererExtension[]));
// @ts-ignore
di.permitSideEffects(getConfigurationFileModelInjectable);
// @ts-ignore
di.permitSideEffects(appVersionInjectable);
UserStore.createInstance();
+15 -15
View File
@@ -956,28 +956,28 @@
"@nodelib/fs.scandir" "2.1.3"
fastq "^1.6.0"
"@ogre-tools/fp@5.1.3", "@ogre-tools/fp@^5.1.3":
version "5.1.3"
resolved "https://registry.yarnpkg.com/@ogre-tools/fp/-/fp-5.1.3.tgz#cf3fe91ecd1dfa9c9d704802e33d1ffe6f6aec44"
integrity sha512-UjSMt+2qxsL6zhnaztMC+6zKROFUgInKcyB+lCjUSyGldHvsCKEQgoLqjVx3R3poB2TcP3i/TASqqeCd6NsogA==
"@ogre-tools/fp@5.2.0", "@ogre-tools/fp@^5.2.0":
version "5.2.0"
resolved "https://registry.yarnpkg.com/@ogre-tools/fp/-/fp-5.2.0.tgz#75d46f5c4304242663c5a9c26544583c107a4755"
integrity sha512-Tm8RfJUmY+Xq8R4XA+B100PI4K0MTpsMq1Li16N3MENFpNP2eGmp1cLR8YhxahMtPPuzKScvlaIybnP6pX/c6Q==
dependencies:
lodash "^4.17.21"
"@ogre-tools/injectable-react@5.1.3":
version "5.1.3"
resolved "https://registry.yarnpkg.com/@ogre-tools/injectable-react/-/injectable-react-5.1.3.tgz#b2983134aa59a9bcce070033d48c1fc957aac389"
integrity sha512-1RRn7CS6vXogYyduI+KfwesunHzcpUi5G4kFz1o3JGDTef8cfpxLUtrCx+fB5AEGybghDQQBl0+rrYRhJ1WPtg==
"@ogre-tools/injectable-react@5.2.0":
version "5.2.0"
resolved "https://registry.yarnpkg.com/@ogre-tools/injectable-react/-/injectable-react-5.2.0.tgz#ec55cd88d3b7e778952d77e6fcb4771f315430d2"
integrity sha512-V1aMIKGIXrhZe6OwhcZ5xm4PLfE9F21KXOXhhz7dXcECWKh0+tHUJaG3MaMPzJqloRSE9SNbMz5nCOv172xRvg==
dependencies:
"@ogre-tools/fp" "^5.1.3"
"@ogre-tools/injectable" "^5.1.3"
"@ogre-tools/fp" "^5.2.0"
"@ogre-tools/injectable" "^5.2.0"
lodash "^4.17.21"
"@ogre-tools/injectable@5.1.3", "@ogre-tools/injectable@^5.1.3":
version "5.1.3"
resolved "https://registry.yarnpkg.com/@ogre-tools/injectable/-/injectable-5.1.3.tgz#766fc7bce85ca666c2de4105feef0769014f72d7"
integrity sha512-VgQhPLEhuavRSFTrOks4IKUVvB7k6mV6sR3vd158ytXKMTP5XMqYWNnBc+DwiUyttKKfi9OLx0Xasg6vxeOR8Q==
"@ogre-tools/injectable@5.2.0", "@ogre-tools/injectable@^5.2.0":
version "5.2.0"
resolved "https://registry.yarnpkg.com/@ogre-tools/injectable/-/injectable-5.2.0.tgz#40c1e3eedc6103d985b6daa124ef6d3eaff0c82c"
integrity sha512-pREfT/51AAWrqBerFc/UCvFN+Xa3U2sgkC0KzHGP5kogjuI1UecWTTChoiO01yoqgfVffqfBoe9uOFs/TzSogQ==
dependencies:
"@ogre-tools/fp" "^5.1.3"
"@ogre-tools/fp" "^5.2.0"
lodash "^4.17.21"
"@panva/asn1.js@^1.0.0":