hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

fix integration tests

Browse Source 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
This commit is contained in:
Jari Kolehmainen 2021-04-27 10:30:43 +03:00
parent 4311f75737
commit 9a65d1b73b
6 changed files with 5 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
integration/__tests__/app.tests.ts
View File

@ -30,10 +30,6 @@ describe("Lens integration tests", () => {
} }
}); });
it('shows "whats new"', async () => {
await utils.clickWhatsNew(app);
});
it('shows "add cluster"', async () => { it('shows "add cluster"', async () => {
await app.electron.ipcRenderer.send("test-menu-item-click", "File", "Add Cluster"); await app.electron.ipcRenderer.send("test-menu-item-click", "File", "Add Cluster");
await app.client.waitUntilTextExists("h2", "Add Clusters from Kubeconfig"); await app.client.waitUntilTextExists("h2", "Add Clusters from Kubeconfig");

2
integration/__tests__/cluster-pages.tests.ts
View File

@ -24,8 +24,6 @@ describe("Lens cluster pages", () => {
utils.describeIf(ready)("test common pages", () => { utils.describeIf(ready)("test common pages", () => {
let clusterAdded = false; let clusterAdded = false;
const addCluster = async () => { const addCluster = async () => {
await utils.clickWhatsNew(app);
await utils.clickWelcomeNotification(app);
await app.client.waitUntilTextExists("div", "Catalog"); await app.client.waitUntilTextExists("div", "Catalog");
await addMinikubeCluster(app); await addMinikubeCluster(app);
await waitForMinikubeDashboard(app); await waitForMinikubeDashboard(app);

1
integration/__tests__/command-palette.tests.ts
View File

@ -18,7 +18,6 @@ describe("Lens command palette", () => {
}); });
it("opens command dialog from menu", async () => { it("opens command dialog from menu", async () => {
await utils.clickWhatsNew(app);
await app.electron.ipcRenderer.send("test-menu-item-click", "View", "Command Palette..."); await app.electron.ipcRenderer.send("test-menu-item-click", "View", "Command Palette...");
await app.client.waitUntilTextExists(".Select__option", "Preferences: Open"); await app.client.waitUntilTextExists(".Select__option", "Preferences: Open");
await app.client.keys("Escape"); await app.client.keys("Escape");

18
integration/helpers/utils.ts
View File

@ -73,24 +73,14 @@ export async function appStart() {
while (await app.client.getWindowCount() > 1); while (await app.client.getWindowCount() > 1);
await app.client.windowByIndex(0); await app.client.windowByIndex(0);
await app.client.waitUntilWindowLoaded(); await app.client.waitUntilWindowLoaded();
await showCatalog(app);
return app; return app;
} }
export async function clickWhatsNew(app: Application) { export async function showCatalog(app: Application) {
await app.client.waitUntilTextExists("h1", "What's new?"); await app.client.waitUntilTextExists("[data-test-id=catalog-link]", "Catalog");
await app.client.click("button.primary"); await app.client.click("[data-test-id=catalog-link]");
await app.client.waitUntilTextExists("div", "Catalog");
}
export async function clickWelcomeNotification(app: Application) {
const itemsText = await app.client.$("div.info-panel").getText();
if (itemsText === "0 items") {
// welcome notification should be present, dismiss it
await app.client.waitUntilTextExists("div.message", "Welcome!");
await app.client.click(".notification i.Icon.close");
}
} }
type AsyncPidGetter = () => Promise<number>; type AsyncPidGetter = () => Promise<number>;

10
src/renderer/components/+catalog/catalog.tsx
View File

@ -13,7 +13,6 @@ import { CatalogEntityContextMenu, CatalogEntityContextMenuContext, catalogEntit
import { Badge } from "../badge"; import { Badge } from "../badge";
import { HotbarStore } from "../../../common/hotbar-store"; import { HotbarStore } from "../../../common/hotbar-store";
import { autobind } from "../../utils"; import { autobind } from "../../utils";
import { Notifications } from "../notifications";
import { ConfirmDialog } from "../confirm-dialog"; import { ConfirmDialog } from "../confirm-dialog";
import { Tab, Tabs } from "../tabs"; import { Tab, Tabs } from "../tabs";
import { catalogCategoryRegistry } from "../../../common/catalog"; import { catalogCategoryRegistry } from "../../../common/catalog";
@ -45,15 +44,6 @@ export class Catalog extends React.Component {
} }
}, { fireImmediately: true }) }, { fireImmediately: true })
]); ]);
setTimeout(() => {
if (this.catalogEntityStore.items.length === 0) {
Notifications.info(<><b>Welcome!</b><p>Get started by associating one or more clusters to Lens</p></>, {
timeout: 30_000,
id: "catalog-welcome"
});
}
}, 2_000);
} }
addToHotbar(item: CatalogEntityItem) { addToHotbar(item: CatalogEntityItem) {

2
src/renderer/components/cluster-manager/bottom-bar.tsx
View File

@ -48,7 +48,7 @@ export class BottomBar extends React.Component {
<div className="BottomBar flex gaps"> <div className="BottomBar flex gaps">
<div id="catalog-link" data-test-id="catalog-link" className="flex gaps align-center" onClick={() => navigate(catalogURL())}> <div id="catalog-link" data-test-id="catalog-link" className="flex gaps align-center" onClick={() => navigate(catalogURL())}>
<Icon smallest material="view_list"/> <Icon smallest material="view_list"/>
<span className="workspace-name" data-test-id="current-workspace-name">Catalog</span> <span className="catalog-link" data-test-id="catalog-link">Catalog</span>
</div> </div>
{this.renderRegisteredItems()} {this.renderRegisteredItems()}
</div> </div>