From 9b7e77dc15a74034a58e53f164b7643ab06579d7 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Tue, 10 Jan 2023 11:35:15 -0500 Subject: [PATCH] Remove unneccessary causesSideEffects Signed-off-by: Sebastian Malton --- src/features/test-utils/application-builder.tsx | 11 ----------- src/renderer/utils/get-element-by-id.injectable.ts | 1 - 2 files changed, 12 deletions(-) diff --git a/src/features/test-utils/application-builder.tsx b/src/features/test-utils/application-builder.tsx index 01ec75c081..14efbc6d3c 100644 --- a/src/features/test-utils/application-builder.tsx +++ b/src/features/test-utils/application-builder.tsx @@ -83,7 +83,6 @@ import { object } from "../../common/utils"; import catalogEntityRegistryInjectable from "../../renderer/api/catalog/entity/registry.injectable"; import createVersionDetectorInjectable from "../../main/cluster-detectors/create-version-detector.injectable"; import type { VersionDetector } from "../../main/cluster-detectors/version-detector"; -import getElementByIdInjectable from "../../renderer/utils/get-element-by-id.injectable"; import { testUsingFakeTime } from "../../common/test-utils/use-fake-time"; type Callback = (di: DiContainer) => void | Promise; @@ -259,16 +258,6 @@ export const setupInitializingApplicationBuilder = (init: (builder: ApplicationB return computed(() => [...rendererExtensionState.values()]); }); - windowDi.override(getElementByIdInjectable, () => (id) => { - const elem = rendered?.container.querySelector(`#${id}`); - - if (!elem) { - throw new Error(`Missing #${id} in DOM`); - } - - return elem; - }); - windowHelpers.set(windowId, { di: windowDi, getRendered: () => rendered }); return { diff --git a/src/renderer/utils/get-element-by-id.injectable.ts b/src/renderer/utils/get-element-by-id.injectable.ts index 89401eb490..7bfcde74e0 100644 --- a/src/renderer/utils/get-element-by-id.injectable.ts +++ b/src/renderer/utils/get-element-by-id.injectable.ts @@ -15,7 +15,6 @@ const getElementByIdInjectable = getInjectable({ return elem; }, - causesSideEffects: true, }); export default getElementByIdInjectable;