From 9c00ca224a8f2b6051c67349677eb12ffa328de4 Mon Sep 17 00:00:00 2001 From: Jari Kolehmainen Date: Fri, 16 Oct 2020 16:55:29 +0300 Subject: [PATCH] fixes Signed-off-by: Jari Kolehmainen --- extensions/telemetry/main.ts | 3 +++ extensions/telemetry/src/tracker.ts | 2 +- src/extensions/extension-api.ts | 3 ++- src/extensions/extension-renderer-api.ts | 3 ++- src/main/index.ts | 4 +++- 5 files changed, 11 insertions(+), 4 deletions(-) diff --git a/extensions/telemetry/main.ts b/extensions/telemetry/main.ts index 6bf2e4d9cb..262980700f 100644 --- a/extensions/telemetry/main.ts +++ b/extensions/telemetry/main.ts @@ -1,14 +1,17 @@ import { LensMainExtension } from "@lens/extensions"; import { telemetryPreferencesStore } from "./src/telemetry-preferences-store" +import { tracker } from "./src/tracker"; export default class TelemetryMainExtension extends LensMainExtension { async onActivate() { console.log("telemetry main extension activated") + tracker.start() await telemetryPreferencesStore.load() } onDeactivate() { + tracker.stop() console.log("telemetry main extension deactivated") } } diff --git a/extensions/telemetry/src/tracker.ts b/extensions/telemetry/src/tracker.ts index 52209b8fa0..cb2ce4a250 100644 --- a/extensions/telemetry/src/tracker.ts +++ b/extensions/telemetry/src/tracker.ts @@ -27,7 +27,7 @@ export class Tracker extends Singleton { } start() { - if (this.started) { return } + if (this.started === true) { return } this.started = true diff --git a/src/extensions/extension-api.ts b/src/extensions/extension-api.ts index 765bcada49..ebd5fa6d71 100644 --- a/src/extensions/extension-api.ts +++ b/src/extensions/extension-api.ts @@ -4,5 +4,6 @@ export type { LensExtensionRuntimeEnv } from "./lens-runtime"; // APIs export * from "./lens-main-extension" export { BaseStore } from "../common/base-store" -export { appEventBus, AppEvent } from "../common/event-bus" +export { appEventBus } from "../common/event-bus" +export type { AppEvent } from "../common/event-bus" export { Singleton } from "../common/utils" diff --git a/src/extensions/extension-renderer-api.ts b/src/extensions/extension-renderer-api.ts index 3759af767c..02b01ade3f 100644 --- a/src/extensions/extension-renderer-api.ts +++ b/src/extensions/extension-renderer-api.ts @@ -6,7 +6,8 @@ export * from "./lens-extension" export * from "./lens-renderer-extension" export { DynamicPageType, PageRegistry } from "./page-registry" export { AppPreferenceRegistry } from "./app-preference-registry" -export { appEventBus, AppEvent } from "../common/event-bus" +export { appEventBus } from "../common/event-bus" +export type { AppEvent } from "../common/event-bus" export { Singleton } from "../common/utils" // TODO: add more common re-usable UI components + refactor interfaces (Props -> ComponentProps) diff --git a/src/main/index.ts b/src/main/index.ts index 4609fd295e..6e12706a66 100644 --- a/src/main/index.ts +++ b/src/main/index.ts @@ -89,7 +89,9 @@ async function main() { extensionLoader.extensions.replace(await extensionManager.load()) extensionLoader.broadcastExtensions() - appEventBus.emit({name: "app", action: "start"}) + setTimeout(() => { + appEventBus.emit({name: "app", action: "start"}) + }, 1000) } app.on("ready", main);