Cascade different refactorings to eliminate global shared state from app paths

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

src/main/__test__/kubeconfig-manager.test.ts

@@ -18,6 +18,7 @@
  * IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
+import { getDiForUnitTesting } from "../getDiForUnitTesting";
 
 const logger = {
   silly: jest.fn(),
@@ -46,41 +47,28 @@ jest.mock("winston", () => ({
   },
 }));
 
-import { KubeconfigManager } from "../kubeconfig-manager";
+import { KubeconfigManager } from "../kubeconfig-manager/kubeconfig-manager";
 import mockFs from "mock-fs";
-import { Cluster } from "../cluster";
-import type { ContextHandler } from "../context-handler";
+import type { Cluster } from "../../common/cluster/cluster";
 import fse from "fs-extra";
 import { loadYaml } from "@kubernetes/client-node";
 import { Console } from "console";
 import * as path from "path";
-import { AppPaths } from "../../common/app-paths";
-
-jest.mock("electron", () => ({
-  app: {
-    getVersion: () => "99.99.99",
-    getName: () => "lens",
-    setName: jest.fn(),
-    setPath: jest.fn(),
-    getPath: () => "tmp",
-    getLocale: () => "en",
-    setLoginItemSettings: jest.fn(),
-  },
-  ipcMain: {
-    on: jest.fn(),
-    handle: jest.fn(),
-  },
-}));
-
-AppPaths.init();
+import createKubeconfigManagerInjectable from "../kubeconfig-manager/create-kubeconfig-manager.injectable";
+import { createClusterInjectionToken } from "../../common/cluster/create-cluster-injection-token";
+import directoryForTempInjectable from "../../common/app-paths/directory-for-temp/directory-for-temp.injectable";
 
 console = new Console(process.stdout, process.stderr); // fix mockFS
 
 describe("kubeconfig manager tests", () => {
   let cluster: Cluster;
-  let contextHandler: ContextHandler;
+  let createKubeconfigManager: (cluster: Cluster) => KubeconfigManager;
+
+  beforeEach(async () => {
+    const di = getDiForUnitTesting({ doGeneralOverrides: true });
+
+    di.override(directoryForTempInjectable, () => "some-directory-for-temp");
 
-  beforeEach(() => {
     const mockOpts = {
       "minikube-config.yml": JSON.stringify({
         apiVersion: "v1",
@@ -107,14 +95,22 @@ describe("kubeconfig manager tests", () => {
 
     mockFs(mockOpts);
 
-    cluster = new Cluster({
+    await di.runSetups();
+
+    const createCluster = di.inject(createClusterInjectionToken);
+
+    createKubeconfigManager = di.inject(createKubeconfigManagerInjectable);
+
+    cluster = createCluster({
       id: "foo",
       contextName: "minikube",
       kubeConfigPath: "minikube-config.yml",
     });
-    contextHandler = {
+
+    cluster.contextHandler = {
       ensureServer: () => Promise.resolve(),
     } as any;
+    
     jest.spyOn(KubeconfigManager.prototype, "resolveProxyUrl", "get").mockReturnValue("http://127.0.0.1:9191/foo");
   });
 
@@ -123,10 +119,10 @@ describe("kubeconfig manager tests", () => {
   });
 
   it("should create 'temp' kube config with proxy", async () => {
-    const kubeConfManager = new KubeconfigManager(cluster, contextHandler);
+    const kubeConfManager = createKubeconfigManager(cluster);
 
     expect(logger.error).not.toBeCalled();
-    expect(await kubeConfManager.getPath()).toBe(`tmp${path.sep}kubeconfig-foo`);
+    expect(await kubeConfManager.getPath()).toBe(`some-directory-for-temp${path.sep}kubeconfig-foo`);
     // this causes an intermittent "ENXIO: no such device or address, read" error
     //    const file = await fse.readFile(await kubeConfManager.getPath());
     const file = fse.readFileSync(await kubeConfManager.getPath());
@@ -138,7 +134,8 @@ describe("kubeconfig manager tests", () => {
   });
 
   it("should remove 'temp' kube config on unlink and remove reference from inside class", async () => {
-    const kubeConfManager = new KubeconfigManager(cluster, contextHandler);
+    const kubeConfManager = createKubeconfigManager(cluster);
+    
     const configPath = await kubeConfManager.getPath();
 
     expect(await fse.pathExists(configPath)).toBe(true);