hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Clear up some NamespaceStore.toggleAll and NamespaceStore.hasAllContexts (#4167)

Browse Source
This commit is contained in:
Sebastian Malton 2021-10-29 08:45:02 -04:00 committed by GitHub
parent 8cbb4c29d5
commit 9e2ee00974
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/renderer/components/+namespaces/namespace-select-filter.tsx
View File

@ -121,10 +121,7 @@ export class NamespaceSelectFilter extends React.Component<SelectProps> {
namespaceStore.toggleSingle(namespace);
}
} else {
/**
* WARNING: only ever call this method with `false` as an argument
*/
namespaceStore.toggleAll(false);
namespaceStore.selectAll();
}
};

31
src/renderer/components/+namespaces/namespace.store.ts
View File

@ -148,8 +148,11 @@ export class NamespaceStore extends KubeObjectStore<Namespace> {
.every(namespace => this.selectedNamespaces.includes(namespace));
}
/**
* Is `true` if all available namespaces are selected, otherwise `false`
*/
@computed get hasAllContexts(): boolean {
return this.selectedNamespaces.length === this.allowedNamespaces.length;
return this.contextNamespaces.length === this.allowedNamespaces.length;
}
@action
@ -167,17 +170,21 @@ export class NamespaceStore extends KubeObjectStore<Namespace> {
this.selectNamespaces(namespace);
}
@action
toggleAll(showAll?: boolean) {
if (typeof showAll === "boolean") {
if (showAll) {
this.selectNamespaces(this.allowedNamespaces);
} else {
this.selectNamespaces([]); // empty context considered as "All namespaces"
}
} else {
this.toggleAll(!this.hasAllContexts);
}
/**
* Selects all available namespaces.
*
* Note: If new namespaces appear in the future those will be selected too
*/
selectAll() {
this.selectNamespaces([]);
}
/**
* @deprecated Use `NamespaceStore.selectAll` instead
*/
toggleAll(selectAll?: boolean) {
void selectAll;
this.selectAll();
}
@action