hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Kludge first unit test with more than minimal data

Browse Source 
This is a kludge because extraction of segregated interface for KubeObject is very difficult. This commit uses actual instance of KubeObject instead as a fake.

Signed-off-by: Janne Savolainen <janne.savolainen@houston-inc.com>
This commit is contained in:
Janne Savolainen 2021-11-04 13:24:49 +02:00 committed by Janne Savolainen
parent 350f07b457
commit a2f9a76add
3 changed files with 66 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
src/renderer/components/kube-object-menu/__snapshots__/kube-object-menu.test.tsx.snap
View File

@ -1,18 +1,25 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP // Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`kube-object-menu given no kube object, renders 1`] = ` exports[`kube-object-menu given kube object, renders 1`] = `
<div> <body>
<i <div>
class="Icon material interactive focusable" <ul
id="menu_actions_1" class="Animate opacity Menu MenuActions flex KubeObjectMenu toolbar gaps right bottom"
tabindex="0"
> >
<span <div>
class="icon" Some menu item
data-icon-name="more_vert" </div>
> </ul>
more_vert </div>
</span> </body>
</i> `;
</div>
exports[`kube-object-menu given no kube object, renders 1`] = `
<body>
<div>
<ul
class="Animate opacity Menu MenuActions flex KubeObjectMenu toolbar gaps right bottom"
/>
</div>
</body>
`; `;

51
src/renderer/components/kube-object-menu/kube-object-menu.test.tsx
View File

@ -23,9 +23,12 @@ import React from "react";
import { render } from "@testing-library/react"; import { render } from "@testing-library/react";
import "@testing-library/jest-dom/extend-expect"; import "@testing-library/jest-dom/extend-expect";
import { KubeObjectMenu } from "./kube-object-menu"; import { KubeObjectMenu } from "./kube-object-menu";
import type { KubeObject } from "../../../common/k8s-api/kube-object"; import { KubeObject } from "../../../common/k8s-api/kube-object";
import type { KubeApi } from "../../../common/k8s-api/kube-api"; import type { KubeApi } from "../../../common/k8s-api/kube-api";
import type { IHasGettableItemsForKind } from "../../../extensions/registries"; import type {
IHasGettableItemsForKind,
KubeObjectMenuRegistration,
} from "../../../extensions/registries";
import type { IGettableStore } from "../../../common/k8s-api/api-manager"; import type { IGettableStore } from "../../../common/k8s-api/api-manager";
import type { KubeObjectStore } from "../../../common/k8s-api/kube-object.store"; import type { KubeObjectStore } from "../../../common/k8s-api/kube-object.store";
import type { IHasName } from "../../../main/cluster"; import type { IHasName } from "../../../main/cluster";
@ -36,11 +39,16 @@ describe("kube-object-menu", () => {
let apiManagerStub: IGettableStore; let apiManagerStub: IGettableStore;
let clusterStub : IHasName; let clusterStub : IHasName;
let kubeObjectMenuRegistryStub: IHasGettableItemsForKind; let kubeObjectMenuRegistryStub: IHasGettableItemsForKind;
let objectStub: any; let objectStub: KubeObject | null;
beforeEach(() => { beforeEach(() => {
// TODO: Remove illegal global overwrites for what should be a dependency somewhere. // TODO: Remove illegal global overwrites for what should be a dependency somewhere.
window.requestIdleCallback = () => 42; // TODO: Remove usage of experimental browser API.
window.requestIdleCallback = (callback: IdleRequestCallback): number => {
callback(undefined);
return undefined;
};
window.cancelIdleCallback = () => {}; window.cancelIdleCallback = () => {};
@ -51,9 +59,18 @@ describe("kube-object-menu", () => {
clusterStub = { name: "Some cluster name" }; clusterStub = { name: "Some cluster name" };
const MenuItemComponentStub : React.FC = () => <div>Some menu item</div>;
const menuItemStub: KubeObjectMenuRegistration = {
apiVersions: ["irrelevant"],
components: { MenuItem: MenuItemComponentStub },
kind: "irrelevant",
};
kubeObjectMenuRegistryStub = { kubeObjectMenuRegistryStub = {
// eslint-disable-next-line unused-imports/no-unused-vars-ts // eslint-disable-next-line unused-imports/no-unused-vars-ts
getItemsForKind: (kind: string, apiVersion: string): any => undefined, getItemsForKind: (kind: string, apiVersion: string): any => [menuItemStub],
}; };
hideDetailsStub = () => {}; hideDetailsStub = () => {};
@ -64,14 +81,34 @@ describe("kube-object-menu", () => {
it("given no kube object, renders", () => { it("given no kube object, renders", () => {
objectStub = null; objectStub = null;
const { container } = render(<KubeObjectMenu object={objectStub} const { baseElement } = render(<KubeObjectMenu object={objectStub}
apiManager={apiManagerStub} apiManager={apiManagerStub}
cluster={clusterStub} cluster={clusterStub}
kubeObjectMenuRegistry={kubeObjectMenuRegistryStub} kubeObjectMenuRegistry={kubeObjectMenuRegistryStub}
hideDetails={hideDetailsStub} hideDetails={hideDetailsStub}
editResourceTab={editResourceTabStub} editResourceTab={editResourceTabStub}
toolbar={true}
/>); />);
expect(container).toMatchSnapshot(); expect(baseElement).toMatchSnapshot();
});
it("given kube object, renders", () => {
objectStub = KubeObject.create({
apiVersion: "some-api-version",
kind: "some-kind",
metadata: { uid: "some-uid", name: "some-name", resourceVersion: "some-resource-version" },
});
const { baseElement } = render(<KubeObjectMenu object={objectStub}
apiManager={apiManagerStub}
cluster={clusterStub}
kubeObjectMenuRegistry={kubeObjectMenuRegistryStub}
hideDetails={hideDetailsStub}
editResourceTab={editResourceTabStub}
toolbar={true}
/>);
expect(baseElement).toMatchSnapshot();
}); });
}); });

1
src/renderer/components/kube-object-menu/kube-object-menu.tsx
View File

@ -34,6 +34,7 @@ export interface KubeObjectMenuProps<TKubeObject> extends MenuActionsProps {
object: TKubeObject | null | undefined; object: TKubeObject | null | undefined;
editable?: boolean; editable?: boolean;
removable?: boolean; removable?: boolean;
toolbar?: boolean;
} }
interface KubeObjectMenuDependencies<TKubeObject> extends KubeObjectMenuProps<TKubeObject>{ interface KubeObjectMenuDependencies<TKubeObject> extends KubeObjectMenuProps<TKubeObject>{