Stop file system watchers on application quit to prevent exit code !== 0 (#7504)

* fix: Dispose the kubeconfig watcher when application quits

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* fix: Dispose the extension watcher when application quits

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

---------

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

packages/core/src/main/catalog-sources/kubeconfig-sync/manager.ts

@@ -98,11 +98,19 @@ export class KubeconfigSyncManager {
 
   @action
   protected stopOldSync(filePath: string): void {
-    if (!this.sources.delete(filePath)) {
-      // already stopped
+    const source = this.sources.get(filePath);
+
+    // already stopped
+    if (!source) {
       return this.dependencies.logger.debug(`no syncing file/folder to stop`, { filePath });
     }
 
+    const [, disposer] = source;
+
+    disposer();
+
+    this.sources.delete(filePath);
+
     this.dependencies.logger.info(`stopping sync of file/folder`, { filePath });
     this.dependencies.logger.debug(`${this.sources.size} files/folders watched`, { files: Array.from(this.sources.keys()) });
   }