From a399b8ee203f85e61c31f7c87a5df4bffb0210d4 Mon Sep 17 00:00:00 2001
From: Sebastian Malton <sebastian@malton.name>
Date: Mon, 8 Nov 2021 10:12:26 -0500
Subject: [PATCH] Fix crash on HorizontalPodAutoscalers view (#4276)

---
 src/renderer/components/+config-autoscalers/hpa.tsx | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/renderer/components/+config-autoscalers/hpa.tsx b/src/renderer/components/+config-autoscalers/hpa.tsx
index 428a84b369..5133aa1d4e 100644
--- a/src/renderer/components/+config-autoscalers/hpa.tsx
+++ b/src/renderer/components/+config-autoscalers/hpa.tsx
@@ -50,11 +50,14 @@ interface Props extends RouteComponentProps<HpaRouteParams> {
 export class HorizontalPodAutoscalers extends React.Component<Props> {
   getTargets(hpa: HorizontalPodAutoscaler) {
     const metrics = hpa.getMetrics();
-    const metricsRemainCount = metrics.length - 1;
-    const metricsRemain = metrics.length > 1 ? <>{metricsRemainCount} more...</> : null;
-    const metricValues = hpa.getMetricValues(metrics[0]);
 
-    return <p>{metricValues} {metricsRemain && "+"}{metricsRemain}</p>;
+    if (metrics.length === 0) {
+      return <p>--</p>;
+    }
+
+    const metricsRemain = metrics.length > 1 ? `+${metrics.length - 1} more...` : "";
+
+    return <p>{hpa.getMetricValues(metrics[0])} {metricsRemain}</p>;
   }
 
   render() {