From a57bd0cb50456a66e0f53302bdb4a59c51fc4b24 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Fri, 29 Oct 2021 10:18:08 -0400 Subject: [PATCH] Revert removing rising edge save of selection state Signed-off-by: Sebastian Malton --- .../components/+namespaces/namespace-select-filter.tsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/renderer/components/+namespaces/namespace-select-filter.tsx b/src/renderer/components/+namespaces/namespace-select-filter.tsx index 566acd25d0..929530aa97 100644 --- a/src/renderer/components/+namespaces/namespace-select-filter.tsx +++ b/src/renderer/components/+namespaces/namespace-select-filter.tsx @@ -60,6 +60,10 @@ export class NamespaceSelectFilter extends React.Component { static isMultiSelection = observable.box(false); static isMenuOpen = observable.box(false); + /** + * Only updated on every open + */ + private selected = observable.set(); private didToggle = false; constructor(props: SelectProps) { @@ -87,6 +91,7 @@ export class NamespaceSelectFilter extends React.Component { disposeOnUnmount(this, [ reaction(() => this.isMenuOpen, newVal => { if (newVal) { // rising edge of selection + this.selected.replace(namespaceStore.selectedNames); this.didToggle = false; } }), @@ -179,7 +184,7 @@ export class NamespaceSelectFilter extends React.Component { formatOptionLabel={this.formatOptionLabel} className="NamespaceSelectFilter" menuClass="NamespaceSelectFilterMenu" - sort={(left, right) => +namespaceStore.selectedNames.has(right.value) - +namespaceStore.selectedNames.has(left.value)} + sort={(left, right) => +this.selected.has(right.value) - +this.selected.has(left.value)} /> );