hendrik/lens
1
0 Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Change typing for after/before window/application start (#7342)

Browse Source 
- Now the callback is provided with an object containing either
  `mainDi` or `windowDi` fields. This should help with confusion
  over which environment the `di` is for

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton authored and GitHub committed 2023-03-13 15:35:33 +02:00
1 parent b99b06980e
commit a63f737adb
62 files changed
+185 -189
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

packages/core/src/common/app-paths/app-paths.test.ts
+2 -2
View File
@@ -38,7 +38,7 @@ describe("app-paths", () => {
userData: "/some-irrelevant-user-data",
};
builder.beforeApplicationStart((mainDi) => {
builder.beforeApplicationStart(({ mainDi }) => {
mainDi.override(
getElectronAppPathInjectable,
() =>
@@ -120,7 +120,7 @@ describe("app-paths", () => {
let windowDi: DiContainer;
beforeEach(async () => {
builder.beforeApplicationStart((mainDi) => {
builder.beforeApplicationStart(({ mainDi }) => {
mainDi.override(
directoryForIntegrationTestingInjectable,
() => "/some-integration-testing-app-data",
packages/core/src/common/utils/channel/channel.test.ts
+4 -4
View File
@@ -50,7 +50,7 @@ describe("channel", () => {
injectionToken: messageChannelListenerInjectionToken,
});
builder.beforeWindowStart((windowDi) => {
builder.beforeWindowStart(({ windowDi }) => {
runInAction(() => {
windowDi.register(testChannelListenerInTestWindowInjectable);
});
@@ -123,7 +123,7 @@ describe("channel", () => {
injectionToken: messageChannelListenerInjectionToken,
});
applicationBuilder.beforeApplicationStart((mainDi) => {
applicationBuilder.beforeApplicationStart(({ mainDi }) => {
runInAction(() => {
mainDi.register(testChannelListenerInMainInjectable);
});
@@ -157,7 +157,7 @@ describe("channel", () => {
handler: () => requestListenerInMainMock,
});
applicationBuilder.beforeApplicationStart((mainDi) => {
applicationBuilder.beforeApplicationStart(({ mainDi }) => {
runInAction(() => {
mainDi.register(testChannelListenerInMainInjectable);
});
@@ -224,7 +224,7 @@ describe("channel", () => {
injectionToken: requestChannelListenerInjectionToken,
});
applicationBuilder.beforeApplicationStart((mainDi) => {
applicationBuilder.beforeApplicationStart(({ mainDi }) => {
runInAction(() => {
mainDi.register(someChannelListenerInjectable);
mainDi.register(someOtherChannelListenerInjectable);
packages/core/src/common/utils/sync-box/sync-box.test.ts
+2 -2
View File
@@ -17,13 +17,13 @@ describe("sync-box", () => {
beforeEach(() => {
applicationBuilder = getApplicationBuilder();
applicationBuilder.beforeApplicationStart(mainDi => {
applicationBuilder.beforeApplicationStart(({ mainDi }) => {
runInAction(() => {
mainDi.register(someInjectable);
});
});
applicationBuilder.beforeWindowStart((windowDi) => {
applicationBuilder.beforeWindowStart(({ windowDi }) => {
runInAction(() => {
windowDi.register(someInjectable);
});