From a7134405cfc7eba203392428bb13f8de56a55922 Mon Sep 17 00:00:00 2001 From: Jari Kolehmainen Date: Fri, 27 Jan 2023 16:48:45 +0200 Subject: [PATCH] Fix missing core styles in dev mode (#7037) Signed-off-by: Jari Kolehmainen --- packages/core/webpack/dev-server.ts | 46 ----------------------------- packages/core/webpack/renderer.ts | 4 +-- 2 files changed, 1 insertion(+), 49 deletions(-) delete mode 100644 packages/core/webpack/dev-server.ts diff --git a/packages/core/webpack/dev-server.ts b/packages/core/webpack/dev-server.ts deleted file mode 100644 index 1f6bc425b4..0000000000 --- a/packages/core/webpack/dev-server.ts +++ /dev/null @@ -1,46 +0,0 @@ -/** - * Copyright (c) OpenLens Authors. All rights reserved. - * Licensed under MIT License. See LICENSE in root directory for more information. - */ - -import Webpack from "webpack"; -import WebpackDevServer from "webpack-dev-server"; -import { webpackLensRenderer } from "./renderer"; -import { buildDir, webpackDevServerPort } from "./vars"; - -/** - * API docs: - * @url https://webpack.js.org/configuration/dev-server/ - * @url https://github.com/chimurai/http-proxy-middleware - */ -const config = webpackLensRenderer({ showVars: false }); -const compiler = Webpack(config); - -const server = new WebpackDevServer({ - setupExitSignals: true, - headers: { - "Access-Control-Allow-Origin": "*", - }, - allowedHosts: "all", - host: "localhost", - port: webpackDevServerPort, - static: buildDir, // aka `devServer.contentBase` in webpack@4 - hot: true, - liveReload: false, - historyApiFallback: true, - compress: true, // enable gzip for everything served - devMiddleware: { - writeToDisk: false, - index: "OpenLensDev.html", - publicPath: "/build", - }, - client: { - reconnect: true, - overlay: false, // don't show warnings and errors on top of rendered app view - logging: "info", - }, -}, compiler); - -console.info(`[WEBPACK-DEV-SERVER]: created with options`, server.options); - -server.start(); diff --git a/packages/core/webpack/renderer.ts b/packages/core/webpack/renderer.ts index 5ef6426956..219dc1de05 100755 --- a/packages/core/webpack/renderer.ts +++ b/packages/core/webpack/renderer.ts @@ -175,9 +175,7 @@ export interface CssModulesWebpackRuleOptions { * Import CSS or SASS styles with modules support (*.module.scss) */ export function cssModulesWebpackRule({ styleLoader }: CssModulesWebpackRuleOptions = {}): webpack.RuleSetRule { - styleLoader ??= isDevelopment - ? "style-loader" - : MiniCssExtractPlugin.loader; + styleLoader ??= MiniCssExtractPlugin.loader; return { test: /\.s?css$/,