diff --git a/extensions/example-extension/webpack.config.js b/extensions/example-extension/webpack.config.js index 94a27a8e08..70ed538264 100644 --- a/extensions/example-extension/webpack.config.js +++ b/extensions/example-extension/webpack.config.js @@ -18,7 +18,6 @@ module.exports = [ externals: [ { "@k8slens/extensions": "var global.LensExtensions", - "mobx": "var global.Mobx", "react": "var global.React" } ], @@ -49,7 +48,6 @@ module.exports = [ { "@k8slens/extensions": "var global.LensExtensions", "react": "var global.React", - "mobx": "var global.Mobx" } ], resolve: { diff --git a/extensions/kube-object-event-status/webpack.config.js b/extensions/kube-object-event-status/webpack.config.js index a35cf40850..5b776a0935 100644 --- a/extensions/kube-object-event-status/webpack.config.js +++ b/extensions/kube-object-event-status/webpack.config.js @@ -19,7 +19,6 @@ module.exports = [ { "@k8slens/extensions": "var global.LensExtensions", "react": "var global.React", - "mobx": "var global.Mobx" } ], resolve: { diff --git a/extensions/license-menu-item/webpack.config.ts b/extensions/license-menu-item/webpack.config.ts index 7b69571cd7..f5846a8b38 100644 --- a/extensions/license-menu-item/webpack.config.ts +++ b/extensions/license-menu-item/webpack.config.ts @@ -19,7 +19,6 @@ export default [ }, externals: { "@k8slens/extensions": "var global.LensExtensions", - "mobx": "var global.Mobx", }, resolve: { extensions: [".tsx", ".ts", ".js"], diff --git a/extensions/metrics-cluster-feature/webpack.config.js b/extensions/metrics-cluster-feature/webpack.config.js index 8d3ea196ba..8ef76c4a30 100644 --- a/extensions/metrics-cluster-feature/webpack.config.js +++ b/extensions/metrics-cluster-feature/webpack.config.js @@ -19,7 +19,6 @@ module.exports = [ { "@k8slens/extensions": "var global.LensExtensions", "react": "var global.React", - "mobx": "var global.Mobx" } ], resolve: { diff --git a/extensions/node-menu/webpack.config.js b/extensions/node-menu/webpack.config.js index a35cf40850..5b776a0935 100644 --- a/extensions/node-menu/webpack.config.js +++ b/extensions/node-menu/webpack.config.js @@ -19,7 +19,6 @@ module.exports = [ { "@k8slens/extensions": "var global.LensExtensions", "react": "var global.React", - "mobx": "var global.Mobx" } ], resolve: { diff --git a/extensions/pod-menu/webpack.config.js b/extensions/pod-menu/webpack.config.js index a35cf40850..5b776a0935 100644 --- a/extensions/pod-menu/webpack.config.js +++ b/extensions/pod-menu/webpack.config.js @@ -19,7 +19,6 @@ module.exports = [ { "@k8slens/extensions": "var global.LensExtensions", "react": "var global.React", - "mobx": "var global.Mobx" } ], resolve: { diff --git a/extensions/survey/package-lock.json b/extensions/survey/package-lock.json index 9bb44b1de4..23a04c2e11 100644 --- a/extensions/survey/package-lock.json +++ b/extensions/survey/package-lock.json @@ -5159,6 +5159,27 @@ "minimist": "^1.2.5" } }, + "mobx": { + "version": "6.2.0", + "resolved": "https://registry.npmjs.org/mobx/-/mobx-6.2.0.tgz", + "integrity": "sha512-j5f16JIq2v4flvYCqaAB9tMtJt/y5efR2OO5Xy+w4/MBMeQ1WeGR0T8BtiNgmxM/OQzPFUKb5DTex9Y8a/yk+g==", + "dev": true + }, + "mobx-react": { + "version": "6.3.1", + "resolved": "https://registry.npmjs.org/mobx-react/-/mobx-react-6.3.1.tgz", + "integrity": "sha512-IOxdJGnRSNSJrL2uGpWO5w9JH5q5HoxEqwOF4gye1gmZYdjoYkkMzSGMDnRCUpN/BNzZcFoMdHXrjvkwO7KgaQ==", + "dev": true, + "requires": { + "mobx-react-lite": "^2.2.0" + } + }, + "mobx-react-lite": { + "version": "2.2.2", + "resolved": "https://registry.npmjs.org/mobx-react-lite/-/mobx-react-lite-2.2.2.tgz", + "integrity": "sha512-2SlXALHIkyUPDsV4VTKVR9DW7K3Ksh1aaIv3NrNJygTbhXe2A9GrcKHZ2ovIiOp/BXilOcTYemfHHZubP431dg==", + "dev": true + }, "move-concurrently": { "version": "1.0.1", "resolved": "https://registry.npmjs.org/move-concurrently/-/move-concurrently-1.0.1.tgz", diff --git a/extensions/survey/package.json b/extensions/survey/package.json index fb8dfcce11..bd6c4718d7 100644 --- a/extensions/survey/package.json +++ b/extensions/survey/package.json @@ -13,11 +13,12 @@ "dev": "webpack --watch", "test": "jest --passWithNoTests --env=jsdom src $@" }, - "dependencies": {}, "devDependencies": { "@k8slens/extensions": "file:../../src/extensions/npm/extensions", "got": "^11.8.1", "jest": "^26.6.3", + "mobx": "^6.2.0", + "mobx-react": "^6.2.2", "node-machine-id": "^1.1.12", "react": "^16.13.1", "refiner-js": "^1.0.1", diff --git a/extensions/survey/src/survey-preferences-store.ts b/extensions/survey/src/survey-preferences-store.ts index 27b42dd869..eda7cf459c 100644 --- a/extensions/survey/src/survey-preferences-store.ts +++ b/extensions/survey/src/survey-preferences-store.ts @@ -1,5 +1,5 @@ import { Store } from "@k8slens/extensions"; -import { observable, toJS, when, makeObservable } from "mobx"; +import { observable, toJS, when } from "mobx"; export type SurveyPreferencesModel = { enabled: boolean; @@ -18,7 +18,6 @@ export class SurveyPreferencesStore extends Store.ExtensionStore extends BaseRegistry { - constructor() { - super(); - - makeObservable(this); - } - add(items: T[], ext: LensExtension) { const normalizedItems = items.map(menuItem => { menuItem.target = { diff --git a/src/main/index.ts b/src/main/index.ts index 4a5208903c..24d885bedd 100644 --- a/src/main/index.ts +++ b/src/main/index.ts @@ -3,7 +3,6 @@ import "../common/system-ca"; import "../common/libs-config"; import "../common/prometheus-providers"; -import * as Mobx from "mobx"; import * as LensExtensions from "../extensions/core-api"; import { app, autoUpdater, ipcMain, dialog, powerMonitor } from "electron"; import { appName, isMac } from "../common/vars"; @@ -254,6 +253,5 @@ export const LensExtensionsApi = { }; export { - Mobx, LensExtensionsApi as LensExtensions, }; diff --git a/src/main/router.ts b/src/main/router.ts index 6fa14e1444..b7d176f0a8 100644 --- a/src/main/router.ts +++ b/src/main/router.ts @@ -139,7 +139,7 @@ export class Router { res.end(); } catch (err) { if (retryCount > 5) { - logger.error("handleStaticFile:", err.toString()); + logger.error("handleStaticFile:", err); res.statusCode = 404; res.end(); diff --git a/src/renderer/bootstrap.tsx b/src/renderer/bootstrap.tsx index 3bb853678f..730bf1ef79 100644 --- a/src/renderer/bootstrap.tsx +++ b/src/renderer/bootstrap.tsx @@ -1,16 +1,14 @@ import "./components/app.scss"; import "../common/libs-config"; -import React from "react"; -import * as Mobx from "mobx"; -import * as MobxReact from "mobx-react"; +import * as React from "react"; import * as ReactRouter from "react-router"; import * as ReactRouterDom from "react-router-dom"; +import * as LensExtensions from "../extensions/extension-api"; import { render, unmountComponentAtNode } from "react-dom"; import { clusterStore } from "../common/cluster-store"; import { userStore } from "../common/user-store"; import { delay } from "../common/utils"; -import { isMac, isDevelopment } from "../common/vars"; -import * as LensExtensions from "../extensions/extension-api"; +import { isDevelopment, isMac } from "../common/vars"; import { extensionDiscovery } from "../extensions/extension-discovery"; import { extensionLoader } from "../extensions/extension-loader"; import { extensionsStore } from "../extensions/extensions-store"; @@ -39,8 +37,6 @@ export { React, ReactRouter, ReactRouterDom, - Mobx, - MobxReact, LensExtensions }; @@ -79,8 +75,8 @@ export async function bootstrap(App: AppComponent) { } }); render(<> - {isMac &&
} - + {isMac &&
} + , rootElem); }