Fix not using the users configured shell for sync (#6589)

* Fix not using the users configured shell for sync

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix issue with use of userShellSetting in ShellSessions

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/common/os/home-directory-path.global-override-for-injectable.ts

@@ -1,9 +0,0 @@
-/**
- * Copyright (c) OpenLens Authors. All rights reserved.
- * Licensed under MIT License. See LICENSE in root directory for more information.
- */
-
-import { getGlobalOverride } from "../test-utils/get-global-override";
-import homeDirectoryPathInjectable from "./home-directory-path.injectable";
-
-export default getGlobalOverride(homeDirectoryPathInjectable, () => "/some-home-directory");

src/common/os/home-directory-path.injectable.ts

@@ -3,12 +3,11 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 import { getInjectable } from "@ogre-tools/injectable";
-import { homedir } from "os";
+import userInfoInjectable from "../user-store/user-info.injectable";
 
 const homeDirectoryPathInjectable = getInjectable({
   id: "home-directory-path",
-  instantiate: () => homedir(),
-  causesSideEffects: true,
+  instantiate: (di) => di.inject(userInfoInjectable).homedir,
 });
 
 export default homeDirectoryPathInjectable;