refactor registering extensions

extension implementors do not need to be aware of disposer and registry internals

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
This commit is contained in:
Jim Ehrismann committed 2020-10-26 16:04:50 -04:00
1 parent e9ebd06664
commit aa1e18c148
7 files changed
+94 -52

No files matched your search

+8 -10
View File
@@ -1,4 +1,4 @@
import { Registry, LensRendererExtension } from "@k8slens/extensions";
import { LensRendererExtension } from "@k8slens/extensions";
import { PodShellMenu } from "./src/shell-menu"
import { PodLogsMenu } from "./src/logs-menu"
import React from "react"
@@ -8,24 +8,22 @@ export default class PodMenuRendererExtension extends LensRendererExtension {
console.log("pod-menu extension activated")
}
registerKubeObjectMenus(registry: Registry.KubeObjectMenuRegistry) {
this.disposers.push(
registry.add({
kubeObjectMenus() {
return [
{
kind: "Pod",
apiVersions: ["v1"],
components: {
MenuItem: (props) => <PodShellMenu {...props} />
}
})
)
this.disposers.push(
registry.add({
},
{
kind: "Pod",
apiVersions: ["v1"],
components: {
MenuItem: (props) => <PodLogsMenu {...props} />
}
})
)
}
]
}
}