From aa46802281f8d7dd230c761d4f0c19b3cec3d62e Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Thu, 17 Sep 2020 14:24:12 -0400 Subject: [PATCH] fix Notifications blocking items not visually under them from being interacted with Signed-off-by: Sebastian Malton --- src/renderer/components/app.scss | 4 ---- src/renderer/components/dock/info-panel.tsx | 18 +++++++++--------- .../notifications/notifications.scss | 4 ++-- 3 files changed, 11 insertions(+), 15 deletions(-) diff --git a/src/renderer/components/app.scss b/src/renderer/components/app.scss index 717c47bb1b..79f46b9efd 100755 --- a/src/renderer/components/app.scss +++ b/src/renderer/components/app.scss @@ -35,10 +35,6 @@ html, body { #app { height: 100%; min-height: 100%; - - > * { - height: inherit; - } } #draggable-top { diff --git a/src/renderer/components/dock/info-panel.tsx b/src/renderer/components/dock/info-panel.tsx index 69e79ad8de..39d998d9d4 100644 --- a/src/renderer/components/dock/info-panel.tsx +++ b/src/renderer/components/dock/info-panel.tsx @@ -62,14 +62,13 @@ export class InfoPanel extends Component { this.error = ""; this.waiting = true; try { - this.result = await this.props.submit().finally(() => { - this.waiting = false; - }); + this.result = await this.props.submit() if (showNotifications) Notifications.ok(this.result); } catch (error) { this.error = error.toString(); if (showNotifications) Notifications.error(this.error); - throw error; + } finally { + this.waiting = false } } @@ -91,12 +90,13 @@ export class InfoPanel extends Component { <> {result && (
- {result} + + {result}
)} {errorInfo && (
- + {errorInfo}
)} @@ -114,9 +114,9 @@ export class InfoPanel extends Component { {controls}
- {waiting ? <> {submittingMessage} : this.renderInfo()} + {waiting ? <> {submittingMessage} : this.renderInfo()}
-